From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C15C76195 for ; Thu, 23 Mar 2023 09:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbjCWJgH (ORCPT ); Thu, 23 Mar 2023 05:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjCWJfk (ORCPT ); Thu, 23 Mar 2023 05:35:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D63C122101 for ; Thu, 23 Mar 2023 02:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679564008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvjK3G8PubwXqQtONySfIeDtd3meQ2XWO8kr4rkCdUw=; b=Zlw1Ha0OeDKk3ojOBCbTMc0J/NhGBylv+k2yRgK50nD+BJGInUxi4207Gu1mJf3s12qPZh Inqjqbw/GSJL+Ck4yjAiD9JJPzGFq+e9/iuVL1EeOvF4N0iU8GJD2l9U0jky+jxnPjYg1A JVTKvcvUhOYf29UpmZX41niy798HyGA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-MvMdG8_EPNanqbYuyUhZow-1; Thu, 23 Mar 2023 05:33:27 -0400 X-MC-Unique: MvMdG8_EPNanqbYuyUhZow-1 Received: by mail-wm1-f71.google.com with SMTP id e5-20020a05600c4e4500b003edc5824521so746221wmq.0 for ; Thu, 23 Mar 2023 02:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679564006; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UvjK3G8PubwXqQtONySfIeDtd3meQ2XWO8kr4rkCdUw=; b=OWREMh57umTsozKznF/FbdZQ2D3M5HN1CjzgY2QJ/qaTHGQ5atTSQjNigjpx4t5kuk HaKv0Z9/WN/BUKuBHYEyzcdgxewiyvEvDM1vEclYUQ4W1phnEaGAkZ3E5o2q/9T1aVK+ jlBlsPmckJ29wxBwL25/h4r504HQX5DQtInjihd7OoWV8jWEt0f8C3IJEgjPpoa+lXBu qgjiGVyjDXlgW8GU9D+ObswH/aXPiUna51meQwJTG21Mzv54SpPD6l+50ym3T/42CXsZ XPlWFA7zm/+DrUg5tXmGCxaZn4Acc1b0KZh35cDE/nv64HdJ00JVGyNHwNrkXhysI8yE TzcA== X-Gm-Message-State: AO0yUKXBCz+Nyg9nbaw16pLyQDHbmK41SGz/yjYzRMo7PovlKqnT180j LR8XByeTXjSFcsZkn+y9s4T1P19LRg794OjwlGNJXOm8Yf/xUwgfAx9CmfIdxvi+eVqTQMNnFmo qXX+Lujooo36RB4Kyqy4AuPaj X-Received: by 2002:a7b:c409:0:b0:3e2:201a:5bcc with SMTP id k9-20020a7bc409000000b003e2201a5bccmr1755000wmi.33.1679564006126; Thu, 23 Mar 2023 02:33:26 -0700 (PDT) X-Google-Smtp-Source: AK7set+dED/VZywkfBRbZ/TenSZ0T7kW9lQyYoxtjIFT5J6quinfNocd9Wx4xJUrnsA9R303Cqb0Rw== X-Received: by 2002:a7b:c409:0:b0:3e2:201a:5bcc with SMTP id k9-20020a7bc409000000b003e2201a5bccmr1754978wmi.33.1679564005817; Thu, 23 Mar 2023 02:33:25 -0700 (PDT) Received: from localhost.localdomain ([151.29.151.163]) by smtp.gmail.com with ESMTPSA id z21-20020a1cf415000000b003ee3e075d1csm1328198wma.22.2023.03.23.02.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 02:33:25 -0700 (PDT) Date: Thu, 23 Mar 2023 10:33:22 +0100 From: Juri Lelli To: Dietmar Eggemann Cc: Ingo Molnar , Peter Zijlstra , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo , Steven Rostedt , Vincent Guittot , Daniel Bristot de Oliveira , Luca Abeni , Tommaso Cucinotta , Qais Yousef , Wei Wang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 0/2] sched/cpuset: Fix DL BW accounting in case can_attach() fails Message-ID: References: <20230322135959.1998790-1-dietmar.eggemann@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322135959.1998790-1-dietmar.eggemann@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 22/03/23 14:59, Dietmar Eggemann wrote: > I followed Longman's idea to add a `deadline task transfer count` into > cpuset and only update the `dl task count` in cpuset_attach(). > > Moreover, I switched from per-task DL BW request to a per-cpuset one. > This way we don't have to free per-task in case xxx_can_attach() fails. > > The DL BW freeing is handled in cpuset_cancel_attach() for the case > `multiple controllers and one of the non-cpuset can_attach() fails`. > > Only lightly tested on cgroup v1 with exclusive cpusets so far. This makes sense to me. Thanks for working on it! Guess I might incorporate these in my (RFC) series and re-post the whole lot? Best, Juri