From: Simon Horman <simon.horman@corigine.com>
To: Tom Rix <trix@redhat.com>
Cc: isdn@linux-pingi.de, nathan@kernel.org, ndesaulniers@google.com,
yangyingliang@huawei.com, alexanderduyck@fb.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg functions
Date: Thu, 23 Mar 2023 19:37:50 +0100 [thread overview]
Message-ID: <ZBycfvJT1cZe3kKs@corigine.com> (raw)
In-Reply-To: <20230323161343.2633836-1-trix@redhat.com>
On Thu, Mar 23, 2023 at 12:13:43PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
> 'vpm_read_address' [-Werror,-Wunused-function]
> vpm_read_address(struct hfc_multi *c)
> ^
>
> drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function
> 'cpld_read_reg' [-Werror,-Wunused-function]
> cpld_read_reg(struct hfc_multi *hc, unsigned char reg)
> ^
>
> These functions are not used, so remove them.
>
> Reported-by: Simon Horman <simon.horman@corigine.com>
FWIIW, says this should go here.
Link: https://lore.kernel.org/netdev/ZBsArtzFkgz+05LK@corigine.com/
> Signed-off-by: Tom Rix <trix@redhat.com>
Patch looks good, thanks.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-23 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:13 [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg functions Tom Rix
2023-03-23 18:37 ` Simon Horman [this message]
2023-03-25 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBycfvJT1cZe3kKs@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexanderduyck@fb.com \
--cc=isdn@linux-pingi.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox