From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31DDC761AF for ; Thu, 23 Mar 2023 22:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbjCWWP3 (ORCPT ); Thu, 23 Mar 2023 18:15:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231311AbjCWWP0 (ORCPT ); Thu, 23 Mar 2023 18:15:26 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE9D52139 for ; Thu, 23 Mar 2023 15:15:25 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id j3-20020a17090adc8300b0023d09aea4a6so3317716pjv.5 for ; Thu, 23 Mar 2023 15:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679609725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o+ylr/mOA4BODFKJbYlALqz8w1nJ4f5MeaN1bApR/jE=; b=ATX4N5q3l1nX9PV91evb3WU0STr9/jdM/snusO6wBEcteYunulqcsKnOIwjro/gSJF GKC6SNXvys0zWLlP0TePikbn/Wbx8LKggQ96aO+SoDGfbi+yVxm6WIo8Zri9kHB3Cf+/ FiBqwY0VADKV0Suyb2GNxFk5IqBl24KTMApGjnRHm5iJuFk0Ubn7zHZNdr92YemH+I0i vbq9izWJHeeVI/Y+KSdX0wwHSPdbQ4cmOEyBN/90C1EWARLATmMHa4h2WduQe4Xyacq6 HbyEPnhnLLBQT2gWz0/9iHBh4c1OZrivrObggg7eDgZST47l47laRXxFVSZOLjFAWysS IQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679609725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o+ylr/mOA4BODFKJbYlALqz8w1nJ4f5MeaN1bApR/jE=; b=d40xy5gb2/X1MDK1hbIPMn8t8z9lIT47d8pbvyFDM/ylkluYInVNE3VHxST29HaX6G ftrWwcBbm77RH4u++iSY8Z+HWqEVCGloA8uoEywF49xNBaI1m5eOyO0BwXajcXLv/5LK A2BexoGT6Czd0hmlghs5a9GdLTr+dXjc9T6V8G/Ck23mJHUJ0C42oPee/iWdwRinSK5Y Jsd2QS4qgFb51JBK13TgR2VQjQDlUNGEFYwf3/SoPWC/tEvtpIj634pz4LJcKaVuYtg5 pinIk6AN752F5Esq7wmOcY+9Udwj3UaNgdOrfWRrSSrmPsG1IjoTxultwDkiDBnzGFbZ +Q1Q== X-Gm-Message-State: AAQBX9dp94mLPiGwXdxXXhMVEaOCo9tlsS6NRuD7GXNGaJudTiQdDdN4 fOjyiryELgvzdr6S7ZuFdAOg21uF98s7E0Kmsyp0Lg== X-Google-Smtp-Source: AKy350akhAgaOXgQONm7ST17i7vfpiD194fM49OYzlB12+MvnMGdHfOrKKPod7Cmc5024KoJROYD+A== X-Received: by 2002:a17:903:32cc:b0:1a1:f5dd:2dde with SMTP id i12-20020a17090332cc00b001a1f5dd2ddemr383893plr.44.1679609725156; Thu, 23 Mar 2023 15:15:25 -0700 (PDT) Received: from google.com (223.103.125.34.bc.googleusercontent.com. [34.125.103.223]) by smtp.gmail.com with ESMTPSA id m16-20020a170902bb9000b0019e88d9bed3sm12733395pls.210.2023.03.23.15.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 15:15:24 -0700 (PDT) Date: Thu, 23 Mar 2023 15:15:20 -0700 From: David Matlack To: Vipin Sharma Cc: seanjc@google.com, pbonzini@redhat.com, bgardon@google.com, jmattson@google.com, mizhang@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v4 12/18] KVM: x86/mmu: Allocate NUMA aware page tables on TDP huge page splits Message-ID: References: <20230306224127.1689967-1-vipinsh@google.com> <20230306224127.1689967-13-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306224127.1689967-13-vipinsh@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 06, 2023 at 02:41:21PM -0800, Vipin Sharma wrote: > + > +void *kvm_mmu_get_free_page(gfp_t gfp, int nid) > +{ > +#ifdef CONFIG_NUMA Is this #ifdef necessary? alloc_pages_node() is defined regardless of CONFIG_NUMA. > + struct page *page; > + > + if (nid != NUMA_NO_NODE) { > + page = alloc_pages_node(nid, gfp, 0); > + if (!page) > + return (void *)0; > + return page_address(page); > + } > +#endif /* CONFIG_NUMA */ > + return (void *)__get_free_page(gfp); > +} > +