From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBBEC76188 for ; Wed, 5 Apr 2023 11:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237340AbjDELSe (ORCPT ); Wed, 5 Apr 2023 07:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230520AbjDELSc (ORCPT ); Wed, 5 Apr 2023 07:18:32 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8733A10C9; Wed, 5 Apr 2023 04:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680693511; x=1712229511; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9FDnGH/JYe0GqhI92TPpxoAKeqbsOMhaQvbTHPwFltg=; b=Hw9mzB4Jl4jbmNIOb1m0hvCsCwRYZVgvkfU5Mx4pBWBhYq/xyMDVwWD+ W6qAFT27xaq5BC7XcVzrCrK8cgj2MkYTPvTOr0wE17cQq/URs3owZRwkr /MJsiLN9xYLd7EQMwQpcCdHreQPMJzPgnV9LaFpQbrqXojTqyzQSjGb/g RqPxnIzlcVjaDKc3nl1fzQ7//bDaJD5qvnsmbpQG7jP0L3E6AeXD4yM6A NOhIkhW/T58DQWTgIPVBgjPOO3fkjvYIydpyf1jXC9qMK8LeA2eqAesoJ vrjrPJu+qpZQrdDL54AaK4+Ym5H08javiWcXU6ZuvUl03gsNWGe86EyIG A==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="322806005" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="322806005" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 04:18:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="776020838" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="776020838" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 05 Apr 2023 04:18:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pk19S-00Co5K-2v; Wed, 05 Apr 2023 14:18:06 +0300 Date: Wed, 5 Apr 2023 14:18:06 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: Olliver Schinagl , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Yehezkel Bernat Subject: Re: [PATCH v1 1/2] iopoll: Introduce ioreadXX_poll_timeout() macros Message-ID: References: <20230330141413.25569-1-andriy.shevchenko@linux.intel.com> <3a348abc-d1f3-364f-88de-a0012fbc0fde@schinagl.nl> <20230405094147.GS33314@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 05, 2023 at 02:15:42PM +0300, Andy Shevchenko wrote: > On Wed, Apr 05, 2023 at 12:41:47PM +0300, Mika Westerberg wrote: > > On Wed, Apr 05, 2023 at 11:58:15AM +0300, Andy Shevchenko wrote: > > > On Fri, Mar 31, 2023 at 10:12:31AM +0200, Olliver Schinagl wrote: > > > > On 30-03-2023 16:14, Andy Shevchenko wrote: ... > > > > But I actually have a small addendum for this series, as it will break > > > > `drivers/net/wwan/t7xx/t7xx_dpmaif.c` due to a redefinition (yeah I know). > > > > > > > > So I have: > > > > https://gitlab.com/olliver/linux/-/commit/c9e591f2dabb2dbaeceebee61fa70b70fdbffc2a > > > > https://gitlab.com/olliver/linux/-/commit/41e0f8c08a1c55940813a240215910336ad7bec2 > > > > https://gitlab.com/olliver/linux/-/commit/f36562f09b0185d403415864ef7218b46a742cdc > > > > https://gitlab.com/olliver/linux/-/commit/66237fd97bc42d272602b01dc0cca541c619b2be > > > > > > > > Which actually replaces silly calls like readx_poll_timeout(ioread32, ... . > > > > > > > > Do you want me to (re-?)post this as a series? I can put your thunderbolt > > > > (and your changes here) and post as one big series (or you can do the same > > > > obviously). > > > > > > I believe the best course of action is to collect this series and your fix > > > in your hands and send it as a material for Linux WWAN subsystem with Mika's > > > Ack (if he has no objections). That said, let's wait for Mika's answer > > > on this. > > > > No objections from my side. > > Thank you, Mika! > > This implies that I stop issuing a new version and Olliver takes over. Olliver, just note that I reduced a lot your initial patch in a sense to add only what is close to the existing users, i.e. ioreadXX() and their atomic versions (no be(), no _rep() variants). If you are objecting that, you need to have yet another patch(es) to prove that there are users. Also note, that I reordered macro appearance to be consistent with existing schema. -- With Best Regards, Andy Shevchenko