From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chanwoo Choi <cwchoi00@gmail.com>
Cc: Bumwoo Lee <bw365.lee@samsung.com>,
linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v1 07/14] extcon: Use unique number for the extcon device ID
Date: Wed, 5 Apr 2023 18:03:02 +0300 [thread overview]
Message-ID: <ZC2NpgQ/JktJAzDm@smile.fi.intel.com> (raw)
In-Reply-To: <f0a40f3a-2ff6-5529-ad84-1c66f7e381ea@gmail.com>
On Mon, Apr 03, 2023 at 11:52:46PM +0900, Chanwoo Choi wrote:
> On 23. 3. 22. 23:39, Andy Shevchenko wrote:
...
> > + ret = ida_simple_get(&extcon_dev_ids, 0, INT_MAX, GFP_KERNEL);
>
>
> ida_simple_get and ida_simple_remove are deprecated on
> commit 3264ceec8f17 ("lib/idr.c: document that ida_simple_{get,remove}()
> are deprecated"). Instead of them, better to use ida_alloc and ida_free
> according to the comments.
Done for v2.
...
> > + ida_simple_remove(&extcon_dev_ids, edev->id);
>
> ditto.
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-05 15:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:39 [PATCH v1 00/14] extcon: Core cleanups and documentation fixes Andy Shevchenko
2023-03-22 14:39 ` [PATCH v1 01/14] extcon: Fix kernel doc of property fields to avoid warnings Andy Shevchenko
2023-04-03 13:50 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 02/14] extcon: Fix kernel doc of property capability " Andy Shevchenko
2023-04-03 13:51 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 03/14] extcon: Use DECLARE_BITMAP() to declare bit arrays Andy Shevchenko
2023-04-03 14:04 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 04/14] extcon: use sysfs_emit() to instead of sprintf() Andy Shevchenko
2023-04-03 14:10 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 05/14] extcon: Amend kernel documentation of struct extcon_dev Andy Shevchenko
2023-04-03 14:10 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 06/14] extcon: Allow name to be assigned outside of the framework Andy Shevchenko
2023-04-03 13:56 ` Chanwoo Choi
2023-03-22 14:39 ` [PATCH v1 07/14] extcon: Use unique number for the extcon device ID Andy Shevchenko
2023-04-03 14:52 ` Chanwoo Choi
2023-04-05 15:03 ` Andy Shevchenko [this message]
2023-03-22 14:39 ` [PATCH v1 08/14] extcon: Switch to use kasprintf_strarray() Andy Shevchenko
2023-04-03 14:58 ` Chanwoo Choi
2023-04-05 8:16 ` Andy Shevchenko
2023-04-05 15:05 ` Andy Shevchenko
2023-03-22 14:40 ` [PATCH v1 09/14] extcon: Use device_match_of_node() helper Andy Shevchenko
2023-04-03 14:14 ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 10/14] extcon: use dev_of_node(dev) instead of dev->of_node Andy Shevchenko
2023-04-03 14:17 ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 11/14] extcon: Remove dup device name in the message and unneeded error check Andy Shevchenko
2023-04-03 14:59 ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 12/14] extcon: Use sizeof(*pointer) instead of sizeof(type) Andy Shevchenko
2023-04-03 14:32 ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 13/14] extcon: Drop unneeded assignments Andy Shevchenko
2023-04-03 15:06 ` Chanwoo Choi
2023-03-22 14:40 ` [PATCH v1 14/14] extcon: Use positive conditional in ternary operator Andy Shevchenko
2023-04-03 14:38 ` Chanwoo Choi
2023-04-05 8:18 ` Andy Shevchenko
2023-03-30 10:11 ` [PATCH v1 00/14] extcon: Core cleanups and documentation fixes Andy Shevchenko
2023-03-31 0:48 ` Bumwoo Lee
2023-04-05 23:17 ` Chanwoo Choi
2023-04-06 0:04 ` Bumwoo Lee
2023-04-06 10:49 ` 'Andy Shevchenko'
2023-04-03 13:58 ` Chanwoo Choi
2023-04-05 8:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC2NpgQ/JktJAzDm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bw365.lee@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox