From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB28EC77B6E for ; Thu, 6 Apr 2023 09:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236702AbjDFJuR (ORCPT ); Thu, 6 Apr 2023 05:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236982AbjDFJts (ORCPT ); Thu, 6 Apr 2023 05:49:48 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D400561AE; Thu, 6 Apr 2023 02:48:16 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pkMCs-0000AJ-2t; Thu, 06 Apr 2023 11:47:03 +0200 Date: Thu, 6 Apr 2023 10:46:59 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , Landen Chao , DENG Qingfang , Sean Wang , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 3/7] dt-bindings: net: dsa: mediatek,mt7530: add port bindings for MT7988 Message-ID: References: <20230406080141.22924-1-arinc.unal@arinc9.com> <20230406080141.22924-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230406080141.22924-3-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 06, 2023 at 11:01:37AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > The switch on MT7988 has got only port 6 as a CPU port. The only phy-mode > to be used is internal. Add this. > > Some bindings are incorrect for this switch now, so move them to more > specific places. > > Address the incorrect information of which ports can be used as a user > port. Any port can be used as a user port. > > Signed-off-by: Arınç ÜNAL Acked-by: Daniel Golle > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 63 ++++++++++++++----- > 1 file changed, 46 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 7045a98d9593..605888ce2bc6 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -160,22 +160,6 @@ patternProperties: > "^(ethernet-)?port@[0-9]+$": > type: object > > - properties: > - reg: > - description: > - Port address described must be 5 or 6 for CPU port and from 0 to 5 > - for user ports. > - > - allOf: > - - if: > - required: [ ethernet ] > - then: > - properties: > - reg: > - enum: > - - 5 > - - 6 > - > required: > - compatible > - reg > @@ -186,9 +170,21 @@ $defs: > "^(ethernet-)?ports$": > patternProperties: > "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 5 or 6 for the CPU port. User > + ports can be 0 to 6. > + > if: > required: [ ethernet ] > then: > + properties: > + reg: > + enum: > + - 5 > + - 6 > + > if: > properties: > reg: > @@ -212,9 +208,21 @@ $defs: > "^(ethernet-)?ports$": > patternProperties: > "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 5 or 6 for the CPU port. User > + ports can be 0 to 6. > + > if: > required: [ ethernet ] > then: > + properties: > + reg: > + enum: > + - 5 > + - 6 > + > if: > properties: > reg: > @@ -235,6 +243,27 @@ $defs: > - 2500base-x > - sgmii > > + mt7988-dsa-port: > + patternProperties: > + "^(ethernet-)?ports$": > + patternProperties: > + "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 6 for the CPU port. User ports > + can be 0 to 3, and 6. > + > + if: > + required: [ ethernet ] > + then: > + properties: > + reg: > + const: 6 > + > + phy-mode: > + const: internal > + > allOf: > - $ref: dsa.yaml#/$defs/ethernet-ports > - if: > @@ -285,7 +314,7 @@ allOf: > compatible: > const: mediatek,mt7988-switch > then: > - $ref: "#/$defs/mt7530-dsa-port" > + $ref: "#/$defs/mt7988-dsa-port" > properties: > gpio-controller: false > mediatek,mcm: false > -- > 2.37.2 >