From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273D1C76195 for ; Mon, 27 Mar 2023 08:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233159AbjC0Iij (ORCPT ); Mon, 27 Mar 2023 04:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233312AbjC0IiU (ORCPT ); Mon, 27 Mar 2023 04:38:20 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21C23A5D2 for ; Mon, 27 Mar 2023 01:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=aVuvyhKAC3iN4VeKP3wIsTfoGjND VWqpZy+lP5v9nwg=; b=LBAqKoHbd85YMHIc+gavwB2Zv/he9yP5vn2JxkwA76Tg +sZAVRMv2DX7xp120nCvawyFcskviiSPpyIF2HDt884shCM/koeTOsAjiFqJiozS V3PuR9kfonZb3uroczdskE869m4pFN00vJf6S4cCpqY0A2uz7R8vz0dVVUVPluQ= Received: (qmail 3064472 invoked from network); 27 Mar 2023 10:32:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 27 Mar 2023 10:32:22 +0200 X-UD-Smtp-Session: l3s3148p1@iKzzlN33lrAujnv6 Date: Mon, 27 Mar 2023 10:32:22 +0200 From: Wolfram Sang To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "sh_eth: remove open coded netif_running()" Message-ID: Mail-Followup-To: Wolfram Sang , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20230327081933.5460-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8eJdQj0TMrNOHpom" Content-Disposition: inline In-Reply-To: <20230327081933.5460-1-wsa+renesas@sang-engineering.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8eJdQj0TMrNOHpom Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 27, 2023 at 10:19:33AM +0200, Wolfram Sang wrote: > This reverts commit ce1fdb065695f49ef6f126d35c1abbfe645d62d5. It turned > out this actually introduces a race condition. netif_running() is not a > suitable check for get_stats. >=20 > Reported-by: Sergey Shtylyov > Signed-off-by: Wolfram Sang Geez, I forgot 'net-next' in $subject. I need to script that somehow... --8eJdQj0TMrNOHpom Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQhVJYACgkQFA3kzBSg KbZ9xg//cBklNc7gsUajNoqwrDg7VlssJEu1Ka/JqsPRnG2UZhIUABFVopXhb/R4 TbD0NheilEIt3AzPYTXqUuygAiMDfWCMKupHYbSXarHb0tJzk+FcO+MDNejFjyUC Wt43BuyVJLEopf6C6XVwXmEBc7s+9WQ66yULyzAtJZQK0b3WfFESvT3HRyleNLzN qn1G+vhw3r10EcsNzK7DyY2XJZCehrT0rNoWh5GDzNTodnOv0yIf+2M3mYnjupF+ lD9bgJDHnQvtu9clwa0lyoTavB9r6ck6GC0iu1CpzvJAp4YUgg6pZMu1pRSgxOx5 9do6k+kC0C3MpVi1LXJ0uBgWZ+ygZqL/Zkjc0Ji3hBQf6CXpHG8ofP6CVZI1UXES NCLIEoP9MKAnMRcaSSxmbzNuFd3LICzL+49nj8jZynj/Q0JX2e9kfPviwlqmnJP3 QqCPf6NwWg+Y2F4iecThuVDuC/2gIS98Y2/GI0ACg0V81dDcIR8lriAHQ71V6TIw r/fBgBR16N5CtibD/GNhtCOtGkqHgRbGHl1L6zn2abn/WlABQwERyvX/db1usn6o QVqwbpkBB5k3fzYWxlFERmj6opbPhwKS0J+swR9e7UaYMNqbqpLApIElHGR4HwYJ MomhZLZFF28w1W9TfSBaeYaDRL+2HJ4p3PEdtlD9YAlF5IyYvAQ= =L1kA -----END PGP SIGNATURE----- --8eJdQj0TMrNOHpom--