From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Igor Artemiev <Igor.A.Artemiev@mcst.ru>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [lvc-project] [PATCH] netfilter: nfnetlink: NULL-check skb->dev in __build_packet_message()
Date: Mon, 27 Mar 2023 12:22:32 +0200 [thread overview]
Message-ID: <ZCFuaDrSdsyzRdgJ@salvia> (raw)
In-Reply-To: <20230327094116.1763201-1-Igor.A.Artemiev@mcst.ru>
On Mon, Mar 27, 2023 at 12:41:16PM +0300, Igor Artemiev wrote:
> After having been compared to NULL value at nfnetlink_log.c:560,
> pointer 'skb->dev' is dereferenced at nfnetlink_log.c:576.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Igor Artemiev <Igor.A.Artemiev@mcst.ru>
> ---
> net/netfilter/nfnetlink_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
> index d97eb280cb2e..2711509eb9a5 100644
> --- a/net/netfilter/nfnetlink_log.c
> +++ b/net/netfilter/nfnetlink_log.c
> @@ -572,7 +572,7 @@ __build_packet_message(struct nfnl_log_net *log,
> }
> }
>
> - if (indev && skb_mac_header_was_set(skb)) {
> + if (indev && skb->dev && skb_mac_header_was_set(skb)) {
This cannot ever happen, we assume skb->dev is always set on.
> if (nla_put_be16(inst->skb, NFULA_HWTYPE, htons(skb->dev->type)) ||
> nla_put_be16(inst->skb, NFULA_HWLEN,
> htons(skb->dev->hard_header_len)))
> --
> 2.30.2
>
next prev parent reply other threads:[~2023-03-27 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:41 [lvc-project] [PATCH] netfilter: nfnetlink: NULL-check skb->dev in __build_packet_message() Igor Artemiev
2023-03-27 10:22 ` Pablo Neira Ayuso [this message]
2023-03-27 15:09 ` Igor A. Artemiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCFuaDrSdsyzRdgJ@salvia \
--to=pablo@netfilter.org \
--cc=Igor.A.Artemiev@mcst.ru \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox