From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "yebin (H)" <yebin10@huawei.com>, Ye Bin <yebin@huaweicloud.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] xfs: fix BUG_ON in xfs_getbmap()
Date: Mon, 27 Mar 2023 18:47:54 -0700 [thread overview]
Message-ID: <ZCJHSsqk4SJEDOTC@infradead.org> (raw)
In-Reply-To: <20230328014328.GG16180@frogsfrogsfrogs>
On Mon, Mar 27, 2023 at 06:43:28PM -0700, Darrick J. Wong wrote:
> <shrug> Seeing as the data fork mappings can change the instant the
> ILOCK drops, I'm not /that/ worried about users seeing a delalloc
> mapping even if the user requested a flush. The results are already
> obsolete when they get to userspace, unless the application software has
> found another means to lock out access to the file.
That is true, but then again the users asked to not see delalloc
mappings, so we really shouldn't report one, right?
next prev parent reply other threads:[~2023-03-28 1:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:02 [PATCH] xfs: fix BUG_ON in xfs_getbmap() Ye Bin
2023-03-27 15:15 ` Darrick J. Wong
2023-03-28 1:33 ` yebin (H)
2023-03-28 1:43 ` Darrick J. Wong
2023-03-28 1:47 ` Christoph Hellwig [this message]
2023-03-28 2:03 ` Darrick J. Wong
2023-03-28 2:58 ` Dave Chinner
2023-03-28 1:44 ` Christoph Hellwig
2023-03-28 1:49 ` Christoph Hellwig
2023-03-27 17:30 ` kernel test robot
2023-03-27 20:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCJHSsqk4SJEDOTC@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox