From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>, outreachy@lists.linux.dev
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jerry Chuang <jerry-chuang@realtek.com>
Subject: Re: [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments
Date: Tue, 28 Mar 2023 10:27:32 +0700 [thread overview]
Message-ID: <ZCJepCj9JcOQqp0Z@debian.me> (raw)
In-Reply-To: <140e0928531e61dc7396271a5b16a6be17514c76.1679945728.git.kamrankhadijadj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]
On Tue, Mar 28, 2023 at 12:49:09AM +0500, Khadija Kamran wrote:
> Linux kernel coding style uses '*/' on a separate line at the end of
> multi line comments.
>
> Fix block comments by moving '*/' at the end of block comments on a
> separate line as reported by checkpatch.pl script.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index dd9903719c20..cbae852478ea 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -244,7 +244,8 @@ void init_rate_adaptive(struct net_device *dev)
> * Output: NONE
> *
> * Return: NONE
> - *---------------------------------------------------------------------------*/
> + *---------------------------------------------------------------------------
> + */
> <snipped>...
> void dm_rf_pathcheck_workitemcallback(struct work_struct *work)
> {
> struct delayed_work *dwork = to_delayed_work(work);
> @@ -2407,7 +2413,8 @@ static void dm_rxpath_sel_byrssi(struct net_device *dev)
> * Output: NONE
> *
> * Return: NONE
> - *---------------------------------------------------------------------------*/
> + *---------------------------------------------------------------------------
> + */
While at above can you please turn these comments above into kernel-doc
comments (see Documentation/doc-guide/kernel-doc.rst for how to write
one)? This requires a placeholder doc where you can write e.g. overview
of the driver and how it is used. The doc should be in
Documentation/driver-api/staging/ (since this is staging driver).
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-03-28 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 19:49 [PATCH v3 0/4] staging: rtl8192u: clean up comments in r8192U_dm.c Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 1/4] staging: rtl8192u: remove change history from comments Khadija Kamran
2023-03-28 3:17 ` Bagas Sanjaya
2023-03-28 5:14 ` Julia Lawall
2023-03-27 19:49 ` [PATCH v3 2/4] staging: rtl8192u: remove commented out code Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 3/4] staging: rtl8192u: add '*' on subsequent lines in block comment Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments Khadija Kamran
2023-03-28 3:27 ` Bagas Sanjaya [this message]
2023-03-28 5:11 ` Greg KH
2023-03-28 8:48 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCJepCj9JcOQqp0Z@debian.me \
--to=bagasdotme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerry-chuang@realtek.com \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox