From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AF7C74A5B for ; Wed, 29 Mar 2023 04:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbjC2Eyq (ORCPT ); Wed, 29 Mar 2023 00:54:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjC2Eyk (ORCPT ); Wed, 29 Mar 2023 00:54:40 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C7E135A1 for ; Tue, 28 Mar 2023 21:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680065631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S01Y/zhEA4qaJvTIo0c2m8xjYqU32cqDPsOeaeS0mgQ=; b=Lao4UjVED30bgIn+zqQ6a5ZVmya9Zsr7ZOX/qalszyQLDJFNQnTNXY5IJma57xzxaBjivz yNIGeW+s/t3DxJ6QcyGVNx2GTkmUOzlS0cxX6083crZDCS8RlkJ7yjiUa8AYxYeINUSssY GD5ibchMiVA+QjnBkdMhBcOZK0dmUiI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-Ii-LZ0zMOzmqRxZZOA6_Ig-1; Wed, 29 Mar 2023 00:53:50 -0400 X-MC-Unique: Ii-LZ0zMOzmqRxZZOA6_Ig-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 418F6101A531; Wed, 29 Mar 2023 04:53:49 +0000 (UTC) Received: from localhost (ovpn-12-137.pek2.redhat.com [10.72.12.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D181B1121331; Wed, 29 Mar 2023 04:53:36 +0000 (UTC) Date: Wed, 29 Mar 2023 12:53:33 +0800 From: Baoquan He To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Matthew Wilcox , David Hildenbrand , Liu Shixin , Jiri Olsa , Jens Axboe , Alexander Viro Subject: Re: [PATCH v8 0/4] convert read_kcore(), vread() to use iterators Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/23 at 10:15am, Lorenzo Stoakes wrote: > While reviewing Baoquan's recent changes to permit vread() access to > vm_map_ram regions of vmalloc allocations, Willy pointed out [1] that it > would be nice to refactor vread() as a whole, since its only user is > read_kcore() and the existing form of vread() necessitates the use of a > bounce buffer. > > This patch series does exactly that, as well as adjusting how we read the > kernel text section to avoid the use of a bounce buffer in this case as > well. > > This has been tested against the test case which motivated Baoquan's > changes in the first place [2] which continues to function correctly, as do > the vmalloc self tests. > > [1] https://lore.kernel.org/all/Y8WfDSRkc%2FOHP3oD@casper.infradead.org/ > [2] https://lore.kernel.org/all/87ilk6gos2.fsf@oracle.com/T/#u The whole series looks good to me. Reviewed-by: Baoquan He