From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>, James Clark <james.clark@arm.com>,
Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
German Gomez <german.gomez@arm.com>,
Sandipan Das <sandipan.das@amd.com>,
Andres Freund <andres@anarazel.de>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v1 0/6] config file/command line for objdump & addr2line
Date: Wed, 29 Mar 2023 10:20:16 -0300 [thread overview]
Message-ID: <ZCQ7EG1+/emX0ZZW@kernel.org> (raw)
In-Reply-To: <20230328235543.1082207-1-irogers@google.com>
Em Tue, Mar 28, 2023 at 04:55:37PM -0700, Ian Rogers escreveu:
> Allow objdump to be set as a perf config file variable. As previously
> objdump was set via the command line, the string was owned by
> argv. Now the string must be strdup-ed, so the corresponding logic
> needs changing with an annotation_options__init/exit.
ui/gtk/annotate.c: In function ‘symbol__gtk_annotate’:
ui/gtk/annotate.c:177:44: error: ‘annotation__default_options’ undeclared (first use in this function); did you mean ‘annotation_options’?
177 | err = symbol__annotate(ms, evsel, &annotation__default_options, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| annotation_options
ui/gtk/annotate.c:177:44: note: each undeclared identifier is reported only once for each function it appears in
make[6]: *** [/var/home/acme/git/perf-tools-next/tools/build/Makefile.build:97: ui/gtk/annotate.o] Error 1
make[6]: *** Waiting for unfinished jobs....
I'll fix this later...
- Arnaldo
> Add command line and config file options for addr2line, set in
> symbol_conf for convenience. This doesn't allow the setting of
> llvm-addr2line due to a bug, but could in the future.
>
> Ian Rogers (6):
> perf annotate: Delete session for debug builds
> perf report: Additional config warnings
> perf annotate: Add init/exit to annotation_options remove default
> perf annotate: Own objdump_path and disassembler_style strings
> perf annotate: Allow objdump to be set in perfconfig
> perf symbol: Add command line support for addr2line path
>
> tools/perf/Documentation/perf-annotate.txt | 3 ++
> tools/perf/Documentation/perf-config.txt | 8 +++-
> tools/perf/Documentation/perf-report.txt | 3 ++
> tools/perf/Documentation/perf-top.txt | 6 +++
> tools/perf/arch/common.c | 4 +-
> tools/perf/arch/common.h | 2 +-
> tools/perf/builtin-annotate.c | 42 +++++++++++++-------
> tools/perf/builtin-report.c | 35 ++++++++++++++---
> tools/perf/builtin-top.c | 27 +++++++++++--
> tools/perf/util/annotate.c | 45 +++++++++++++++++-----
> tools/perf/util/annotate.h | 9 +++--
> tools/perf/util/srcline.c | 26 ++++++++-----
> tools/perf/util/symbol_conf.h | 1 +
> 13 files changed, 163 insertions(+), 48 deletions(-)
>
> --
> 2.40.0.348.gf938b09366-goog
>
--
- Arnaldo
prev parent reply other threads:[~2023-03-29 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 23:55 [PATCH v1 0/6] config file/command line for objdump & addr2line Ian Rogers
2023-03-28 23:55 ` [PATCH v1 1/6] perf annotate: Delete session for debug builds Ian Rogers
2023-03-29 13:09 ` Arnaldo Carvalho de Melo
2023-03-29 13:18 ` Arnaldo Carvalho de Melo
2023-03-30 0:13 ` Namhyung Kim
2023-03-30 11:24 ` Arnaldo Carvalho de Melo
2023-03-30 16:59 ` Ian Rogers
2023-03-28 23:55 ` [PATCH v1 2/6] perf report: Additional config warnings Ian Rogers
2023-03-28 23:55 ` [PATCH v1 3/6] perf annotate: Add init/exit to annotation_options remove default Ian Rogers
2023-03-28 23:55 ` [PATCH v1 4/6] perf annotate: Own objdump_path and disassembler_style strings Ian Rogers
2023-03-29 13:17 ` Arnaldo Carvalho de Melo
2023-03-28 23:55 ` [PATCH v1 5/6] perf annotate: Allow objdump to be set in perfconfig Ian Rogers
2023-03-28 23:55 ` [PATCH v1 6/6] perf symbol: Add command line support for addr2line path Ian Rogers
2023-03-30 0:15 ` Namhyung Kim
2023-03-29 13:20 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCQ7EG1+/emX0ZZW@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andres@anarazel.de \
--cc=german.gomez@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox