From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: "Sahin, Okan" <Okan.Sahin@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Cosmin Tanislav <demonsingur@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
ChiYuan Huang <cy_huang@richtek.com>,
"Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>,
William Breathitt Gray <william.gray@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, ChiaEn Wu <chiaen_wu@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support
Date: Wed, 29 Mar 2023 17:43:51 +0300 [thread overview]
Message-ID: <ZCROpw0il1VQCLPu@smile.fi.intel.com> (raw)
In-Reply-To: <20230329143615.GS2673958@google.com>
On Wed, Mar 29, 2023 at 03:36:15PM +0100, Lee Jones wrote:
> On Tue, 28 Mar 2023, Sahin, Okan wrote:
> > >On Wed, 15 Mar 2023, Lee Jones wrote:
> > >> On Tue, 07 Mar 2023, Okan Sahin wrote:
...
> > +static const struct i2c_device_id max77541_i2c_id[] = {
> > + { "max77540", (kernel_ulong_t)&chip[MAX77540] },
> > + { "max77541", (kernel_ulong_t)&chip[MAX77541] },
>
> Just 'MAX77540' is fine.
I tend to disagree.
There is an error prone approach esp. when we talk with some functions
that unifies OF/ACPI driver data retrieval with legacy ID tables.
In such a case the 0 from enum is hard to distinguish from NULL when
the driver data is not set or not found. On top of that the simple integer
in the legacy driver data will require additional code to be added in
the ->probe().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-29 14:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:28 [PATCH v6 0/5] Add MAX77541/MAX77540 PMIC Support Okan Sahin
2023-03-07 11:28 ` [PATCH v6 1/5] dt-bindings: regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Okan Sahin
2023-03-07 11:28 ` [PATCH v6 2/5] regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Support Okan Sahin
2023-03-07 12:19 ` Andy Shevchenko
2023-04-04 14:05 ` Sahin, Okan
2023-03-07 11:28 ` [PATCH v6 3/5] iio: adc: max77541: Add ADI MAX77541 ADC Support Okan Sahin
2023-03-07 11:28 ` [PATCH v6 4/5] dt-bindings: mfd: max77541: Add ADI MAX77541/MAX77540 Okan Sahin
2023-03-07 11:28 ` [PATCH v6 5/5] mfd: max77541: Add ADI MAX77541/MAX77540 PMIC Support Okan Sahin
2023-03-15 17:52 ` Lee Jones
2023-03-15 17:52 ` Lee Jones
2023-03-28 8:26 ` Sahin, Okan
2023-03-28 12:51 ` Andy Shevchenko
2023-03-28 13:26 ` Nuno Sá
2023-03-28 13:46 ` Mark Brown
2023-03-28 14:18 ` Nuno Sá
2023-03-28 14:35 ` Andy Shevchenko
2023-03-28 14:44 ` Lars-Peter Clausen
2023-03-28 14:51 ` Nuno Sá
2023-03-28 15:47 ` Andy Shevchenko
2023-03-28 16:01 ` Sahin, Okan
2023-03-29 14:08 ` Andy Shevchenko
2023-03-29 14:11 ` Andy Shevchenko
2023-03-30 7:43 ` Nuno Sá
2023-03-29 7:01 ` Nuno Sá
2023-03-29 14:06 ` Andy Shevchenko
2023-03-28 15:24 ` Mark Brown
2023-03-29 14:36 ` Lee Jones
2023-03-29 14:43 ` Andy Shevchenko [this message]
2023-03-29 14:56 ` Lee Jones
2023-03-29 15:06 ` Lee Jones
2023-03-30 8:04 ` Krzysztof Kozlowski
2023-03-30 8:07 ` Krzysztof Kozlowski
2023-04-03 11:40 ` Sahin, Okan
2023-04-03 14:09 ` Lee Jones
2023-04-05 8:36 ` Andy Shevchenko
2023-04-05 13:39 ` Lee Jones
2023-04-09 16:48 ` Sahin, Okan
2023-04-12 10:04 ` Lee Jones
2023-04-12 10:44 ` Sahin, Okan
2023-03-30 8:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCROpw0il1VQCLPu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=Okan.Sahin@analog.com \
--cc=Ramona.Bolboaca@analog.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox