Re: [PATCH] fs: consolidate duplicate dt_type helpers

Jeff Layton
2023-03-30T11:15:49Z

On Thu, 2023-03-30 at 12:48 +0200, Greg Kroah-Hartman wrote:
> On Thu, Mar 30, 2023 at 06:41:43AM -0400, Jeff Layton wrote:
> > There are three copies of the same dt_type helper sprinkled around the
> > tree. Convert them to use the common fs_umode_to_dtype function instead,
> > which has the added advantage of properly returning DT_UNKNOWN when
> > given a mode that contains an unrecognized type.
> >
> > Cc: Chuck Lever <chuck.lever@oracle.com>
> > Cc: Phillip Potter <phil@philpotter.co.uk>
> > Suggested-by: Christian Brauner <brauner@kernel.org>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/configfs/dir.c | 9 ++-------
> > fs/kernfs/dir.c | 8 +-------
> > fs/libfs.c | 9 ++-------
> > 3 files changed, 5 insertions(+), 21 deletions(-)
> >
> > v2: consolidate S_DT helper as well
> > v3: switch existing dt_type helpers to use fs_umode_to_dtype
> > drop v9fs hunks since they're no longer needed
>
> You forgot the "v3" in the subject line :(
>

Yeah, I noticed, sorry. It's the attention to detail that makes me such
a successful kernel developer! ;)
--
Jeff Layton <jlayton@kernel.org>