Re: [PATCH v2] Documentation: Add document for false sharing

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Wed, Mar 29, 2023 at 09:51:56PM -0700, Shakeel Butt wrote:
> > > +* Turn hot global data to 'per-cpu data + global data' when possible,
> > > +  or reasonably increase the threshold for syncing per-cpu data to
> > > +  global data, to reduce or postpone the 'write' to that global data.
> > > +
> > > +  - Commit 520f897a3554 ("ext4: use percpu_counters for extent_status cache hits/misses")
> > > +  - Commit 56f3547bfa4d ("mm: adjust vm_committed_as_batch according to vm overcommit policy")
> > > +
> >
> > Here's what I mean by bridging conjunctions to example commits as I reviewed
> > in v1 [1]:
> >
> 
> This is too much and unneeded nitpicking. The patch looks good as is.

As ESL people, I feel there is a gap when a description paragraph is
followed immediately by some sort of lists without bridging (conjunction
between them). I expect a smooth transition in this case. Even though
before the list it is written "(with examples)", I think the conjunction
is needed anyway.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]