From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40441C6FD1D for ; Thu, 30 Mar 2023 21:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjC3VQe (ORCPT ); Thu, 30 Mar 2023 17:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbjC3VQT (ORCPT ); Thu, 30 Mar 2023 17:16:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2544C19A6; Thu, 30 Mar 2023 14:16:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDED8621AE; Thu, 30 Mar 2023 21:16:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1023C433EF; Thu, 30 Mar 2023 21:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680210978; bh=ooDK8+6y9Kfl0/zn/9ZI2cFoW7WtHh5MrFLIEToNiIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uNYvhDsrd/8GYB4SrpR4BA1Vfz2wk8PiEsL9XRLUpzDFfMoMls1tgud9ukrx0azHj JvzJkEnzphOTnxtfBRgaQ5PIfQzkq/JDRnTAO8zTdvrgLmuf3krSiosoGpIeVKBnZ7 Gqa04fN9aWWXGsZbWYJuQyeVdE1qfsMOWgKBsLKGhjDGGEbEa0QaifrwktZmC3JTh3 PboJCO8b6NNrcngCMt00P8DTIZvFB+BDNUlKoCaFBY+iiOSa7v34nuzNjqSW4Cu8U1 gmR7v3tj3XO2IV1pLRQO5cZEa0duPe2Qd9bPP63wJB7YpmSY/zBzsW5cWBkyffMQlh 1K2ObDSWMGRnQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id A6B004052D; Thu, 30 Mar 2023 18:16:15 -0300 (-03) Date: Thu, 30 Mar 2023 18:16:15 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Andreas Herrmann , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH] perf bench numa: Fix for loop in do_work Message-ID: References: <20230330074202.14052-1-aherrmann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Mar 30, 2023 at 09:31:31AM +0100, James Clark escreveu: > > > On 30/03/2023 08:42, Andreas Herrmann wrote: > > j is of type int and start/end are of type long. Thus j might become > > negative and cause segfault in access_data(). Fix it by using long for > > j as well. > > Signed-off-by: Andreas Herrmann > > --- > > tools/perf/bench/numa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Example of segfault (with 6.3.0-rc4) is: > > > > # ./perf bench numa mem -d -m -p 2 -t 12 -P 25425 > > ... > > threads initialized in 6.052135 seconds. > > # > > perf: bench/numa.c:1654: __bench_numa: Assertion `!(!(((wait_stat) & 0x7f) == 0))' failed. > > Aborted (core dumped) > > # dmesg | grep segfault > > [78812.711311] thread 1/3[43215]: segfault at 7f07936c9ec0 ip 00000000004ab6d0 sp 00007f0acb1f9cb0 error 4 > > [78812.711309] thread 1/9[43221]: segfault at 7f08bda71a70 ip 00000000004ab6d0 sp 00007f0ac81f3cb0 error 4 > > [78812.711316] thread 1/4[43216]: segfault at 7f07ccf76a08 ip 00000000004ab6d0 sp 00007f0aca9f8cb0 error 4 > > [78812.711325] thread 1/2[43214]: segfault at 7f08be2f44b0 ip 00000000004ab6d0 sp 00007f0acb9facb0 error 4 > > [78812.711328] thread 1/8[43220]: segfault at 7f06d3096b20 ip 00000000004ab6d0 sp 00007f0ac89f4cb0 error 4 > > [78812.711345] thread 1/6[43218]: segfault at 7f0774b46a18 ip 00000000004ab6d0 sp 00007f0ac99f6cb0 error 4 in perf[400000+caa000] likely on CPU 6 (core 8, socket 0) > > [78812.711366] thread 0/0[43224]: segfault at 7f08a936b130 ip 00000000004ab6d0 sp 00007f0acc9fccb0 error 4 in perf[400000+caa000] likely on CPU 1 (core 1, socket 0) > > > > diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c > > index 9717c6c17433..1fbd7c947abc 100644 > > --- a/tools/perf/bench/numa.c > > +++ b/tools/perf/bench/numa.c > > @@ -847,7 +847,7 @@ static u64 do_work(u8 *__data, long bytes, int nr, int nr_max, int loop, u64 val > > > > if (g->p.data_rand_walk) { > > u32 lfsr = nr + loop + val; > > - int j; > > + long j; > > > > for (i = 0; i < words/1024; i++) { > > long start, end; > > Reviewed-by: James Clark Thanks, applied. - Arnaldo