Re: [PATCH 07/29] selftests/mm: Merge default_huge_page_size() into one

Mike Kravetz
2023-03-31T18:15:57Z

On 03/30/23 12:07, Peter Xu wrote:
> There're already 3 same definitions of the three functions. Move it into
> vm_util.[ch].
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> tools/testing/selftests/mm/hugetlb-madvise.c | 25 +-------------------
> tools/testing/selftests/mm/thuge-gen.c | 19 +--------------
> tools/testing/selftests/mm/userfaultfd.c | 24 -------------------
> tools/testing/selftests/mm/vm_util.c | 21 ++++++++++++++++
> tools/testing/selftests/mm/vm_util.h | 1 +
> 5 files changed, 24 insertions(+), 66 deletions(-)

Thanks!

Some of those copies were make by me. Sorry.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

BTW - The same code (even with '... copied from mlock2-tests.c) resides
in the selftests/memfd directory. I did that as well. :( Suspect it is OK
to leave the copy there. But, it does make me wonder why memfd is not in
the mm directory?
--
Mike Kravetz