public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thorsten Leemhuis <regressions@leemhuis.info>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Alex Dubov <oakad@yahoo.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Jens Axboe <axboe@kernel.dk>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Hannes Reinecke <hare@suse.de>,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	ye xingchen <ye.xingchen@zte.com.cn>,
	linux-mmc@vger.kernel.org
Subject: Re: BUG FIX: [PATCH RFC v3] memstick_check() memleak in kernel 6.1.0+ introduced pre 4.17
Date: Sat, 1 Apr 2023 08:28:07 +0200	[thread overview]
Message-ID: <ZCfO90WwyS6JwaHi@kroah.com> (raw)
In-Reply-To: <4d80549f-e59d-6319-07fd-1fbed75d7a1c@alu.unizg.hr>

On Sat, Apr 01, 2023 at 08:23:26AM +0200, Mirsad Goran Todorovac wrote:
> > This patch is implying that anyone who calls "dev_set_name()" also has
> > to do this hack, which shouldn't be the case at all.
> > 
> > thanks,
> > 
> > greg k-h
> 
> This is my best guess. Unless there is dev_free_name() or kobject_free_name(), I don't
> see a more sensible way to patch this up.

In sleeping on this, I think this has to move to the driver core.  I
don't understand why we haven't seen this before, except maybe no one
has really noticed before (i.e. we haven't had good leak detection tools
that run with removable devices?)

Anyway, let me see if I can come up with something this weekend, give me
a chance...

thanks,

greg k-h

  reply	other threads:[~2023-04-01  6:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 13:20 BUG: memstick_check() memleak in kernel 6.1.0+ introduced pre 4.17 Mirsad Goran Todorovac
2023-03-29 17:25 ` BUG FIX: [PATCH v1] " Mirsad Goran Todorovac
2023-03-31 14:46   ` BUG FIX: [PATCH RFC v2] " Mirsad Goran Todorovac
2023-03-31 16:32     ` Greg KH
2023-03-31 20:48       ` Mirsad Goran Todorovac
2023-04-01  6:23       ` BUG FIX: [PATCH RFC v3] " Mirsad Goran Todorovac
2023-04-01  6:28         ` Greg KH [this message]
2023-04-01  6:33           ` Greg KH
2023-04-01  9:18             ` Greg KH
2023-04-01  9:23               ` Greg KH
2023-04-01  9:52                 ` Mirsad Goran Todorovac
2023-04-01 10:01                   ` Mirsad Goran Todorovac
2023-04-01 10:14                     ` Greg KH
2023-04-01 10:38                       ` Mirsad Goran Todorovac
2023-04-01 11:25                 ` BUG FIX: [PATCH RFC v3] [TESTED OK] " Mirsad Goran Todorovac
2023-04-01 14:56                   ` Greg KH
2023-04-04 10:37                     ` Mirsad Goran Todorovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCfO90WwyS6JwaHi@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=hare@suse.de \
    --cc=jiasheng@iscas.ac.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=mirsad.todorovac@alu.unizg.hr \
    --cc=oakad@yahoo.com \
    --cc=regressions@leemhuis.info \
    --cc=ulf.hansson@linaro.org \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox