From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3BFC77B60 for ; Sat, 1 Apr 2023 06:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbjDAGdq (ORCPT ); Sat, 1 Apr 2023 02:33:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjDAGdp (ORCPT ); Sat, 1 Apr 2023 02:33:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 211081D85C; Fri, 31 Mar 2023 23:33:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1B8EB832B2; Sat, 1 Apr 2023 06:33:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0847EC433EF; Sat, 1 Apr 2023 06:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680330819; bh=d70Vp8SNdPL0Uf4Gb8aXU2perlHFjj5G3Axx7WjxzYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A+ZuQgTCa5Qmy2Rxm6+7EV+2kGx6gz+OrviWZhznK9QTPAgPROVDCdahjcBYKZF+w 3kbqR1cdVu8dDF1pZ6Hn68yv5PgsOr8FQs7eKCUi0DLzabBmRrg04o8BBe3Ll8+N74 yQc/lyhvny53egzpRPxslwHxFR+zDizHpJIuL870= Date: Sat, 1 Apr 2023 08:33:36 +0200 From: Greg KH To: Mirsad Goran Todorovac Cc: LKML , Thorsten Leemhuis , Maxim Levitsky , Alex Dubov , Ulf Hansson , Jens Axboe , Christophe JAILLET , Hannes Reinecke , Jiasheng Jiang , ye xingchen , linux-mmc@vger.kernel.org Subject: Re: BUG FIX: [PATCH RFC v3] memstick_check() memleak in kernel 6.1.0+ introduced pre 4.17 Message-ID: References: <7d873dd3-9bab-175b-8158-c458b61a7122@alu.unizg.hr> <2023033124-causing-cassette-4d96@gregkh> <4d80549f-e59d-6319-07fd-1fbed75d7a1c@alu.unizg.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 01, 2023 at 08:28:07AM +0200, Greg KH wrote: > On Sat, Apr 01, 2023 at 08:23:26AM +0200, Mirsad Goran Todorovac wrote: > > > This patch is implying that anyone who calls "dev_set_name()" also has > > > to do this hack, which shouldn't be the case at all. > > > > > > thanks, > > > > > > greg k-h > > > > This is my best guess. Unless there is dev_free_name() or kobject_free_name(), I don't > > see a more sensible way to patch this up. > > In sleeping on this, I think this has to move to the driver core. I > don't understand why we haven't seen this before, except maybe no one > has really noticed before (i.e. we haven't had good leak detection tools > that run with removable devices?) > > Anyway, let me see if I can come up with something this weekend, give me > a chance... Wait, no, this already should be handled by the kobject core, look at kobject_cleanup(), at the bottom. So your change should be merely duplicating the logic there that already runs when the struct device is freed, right? So I don't understand why your change works, odd. I need more coffee... thanks, greg k-h