From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting
Date: Sat, 1 Apr 2023 18:46:25 -0700 [thread overview]
Message-ID: <ZCjecTFJKnsiwJmT@google.com> (raw)
In-Reply-To: <20230322064158.4043-1-jiapeng.chong@linux.alibaba.com>
Hi Jiapeng,
On Wed, Mar 22, 2023 at 02:41:58PM +0800, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/input/misc/cma3000_d0x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
> index e6feb73bb52b..c444a44e4576 100644
> --- a/drivers/input/misc/cma3000_d0x.c
> +++ b/drivers/input/misc/cma3000_d0x.c
> @@ -325,7 +325,7 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
> input_dev->open = cma3000_open;
> input_dev->close = cma3000_close;
>
> - __set_bit(EV_ABS, input_dev->evbit);
> + __set_bit(EV_ABS, input_dev->evbit);
We should simply remove this, as input_set_abs_params() will set EV_ABS
bit for us.
>
> input_set_abs_params(input_dev, ABS_X,
> -data->g_range, data->g_range, pdata->fuzz_x, 0);
> --
> 2.20.1.7.g153144c
>
Thanks.
--
Dmitry
prev parent reply other threads:[~2023-04-02 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 6:41 [PATCH] Input: cma3000_d0x - Clean up some inconsistent indenting Jiapeng Chong
2023-04-02 1:46 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCjecTFJKnsiwJmT@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox