From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Yinbo Zhu <zhuyinbo@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v6 2/2] spi: loongson: add bus driver for the loongson spi controller
Date: Sun, 2 Apr 2023 16:41:41 +0100 [thread overview]
Message-ID: <ZCmiNSxMWmdolMub@sirena.org.uk> (raw)
In-Reply-To: <9fcb66fa-aadc-8660-bd4a-452c4811ced9@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Sun, Apr 02, 2023 at 12:04:00PM +0200, Krzysztof Kozlowski wrote:
> On 01/04/2023 11:56, Yinbo Zhu wrote:
> > +static inline void loongson_spi_write_reg(struct loongson_spi *spi, unsigned char reg,
> > + unsigned char data)
> > +{
> > + writeb(data, spi->base + reg);
> This wrapper does not simplify anything.
This is an *extremely* standard wrapper which adds the base and
register to work out the address to write to without having to
duplicate it for every caller. There is absolutely nothing wrong
with it, or the read equivalent - they are useful and helpful.
> > +#define LOONGSON_SPI_SPCR_REG 0x00
> There is just one space after #define.
It's using a tab which is again not the end of the world.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-02 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 9:56 [PATCH v6 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-04-01 9:56 ` [PATCH v6 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-04-02 9:58 ` Krzysztof Kozlowski
2023-04-03 7:37 ` zhuyinbo
2023-04-01 9:56 ` [PATCH v6 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-04-02 10:04 ` Krzysztof Kozlowski
2023-04-02 15:41 ` Mark Brown [this message]
2023-04-03 9:35 ` zhuyinbo
2023-04-02 11:44 ` Christophe JAILLET
2023-04-03 7:44 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCmiNSxMWmdolMub@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox