From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8363CC76196 for ; Mon, 3 Apr 2023 01:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231182AbjDCBW1 (ORCPT ); Sun, 2 Apr 2023 21:22:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjDCBWX (ORCPT ); Sun, 2 Apr 2023 21:22:23 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A279AF1A for ; Sun, 2 Apr 2023 18:21:59 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id eh3so111051560edb.11 for ; Sun, 02 Apr 2023 18:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680484916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cy9vAKh1SRYsjRJ8W4Bk+i1NkUBPumqbVrEbWjhh5Fc=; b=X9MbgiVAqpAsMwjKEaSh1WtuNTtZP+qfKhbY0jGwZFSScHv16z4rRic/5SO9E0ZMDO Ut0paFXlg6zg1emacna3VdXOs9WevneldVXVYmD5SIUKMdBHqklbqOeBKoRpjIqFG7LR +Q+KvC2qNwDVOQADLPQsDIP3DtuulQIObKkygyz31ooSXCzCl1cia/2+9gZ+6oekvbIb j73kvCPkeVcb5IGBtT3/qA5YGCLUnQZpHjxbFX/oseJOQAjq62SCPBoHOOw1HAKOCsNw JIuBJO5VNcP57WdvS2k7YZve6DiIcSSlmVhwQo10NTAaQsJ8ojwsZLpsZVGR+86vzDxe TbsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680484916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cy9vAKh1SRYsjRJ8W4Bk+i1NkUBPumqbVrEbWjhh5Fc=; b=VIrUxogHHVNdMLYUORUN2WM8jw2IESjAiffuNExEMQEyGnUk+z/rgLg97FqhGcuRXF kLKx6hKiRKXDx1AlQvnsIbaMsvhNQRxs2ReB9HM6X0Bbb+v36Ef0aI+ZjCsuUgf0ktJM tDZqOOvVHUUN8dky58L0oVcBgzpn+A/OKmcfvKeSOkXWS7Dd4QkNRWVUcIniQWf5uSMz bt69RB8X79e4kdQ/QSe45uILdd6m9GDu30iRfk6sZB/Y6d0BkE1Nd5THmasjEi61nfjW fA61jit1A5wTKx0aSuvhOLaKAv0zci0QmH3lM3PcMRHEYBHlyQ32AAZrTSiLx4pIDYNT pPXQ== X-Gm-Message-State: AAQBX9f4HdNHzXdFQbTOm9vNu4YYPKkM8kX7C++hm4cqxuEJyNX2rikz bg68ti6tQDDW67DmP5rySjk= X-Google-Smtp-Source: AKy350bNl1jreipDIob/3r+nXH8ZnNBarE8ORo0800gplNiVNhtpMvqSInA6zXj85vzaItVXHL2H/g== X-Received: by 2002:a17:906:8053:b0:93b:5f2:36c with SMTP id x19-20020a170906805300b0093b05f2036cmr30131818ejw.61.1680484916462; Sun, 02 Apr 2023 18:21:56 -0700 (PDT) Received: from khadija-virtual-machine ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id b14-20020a17090630ce00b0094596ff8240sm3783596ejb.110.2023.04.02.18.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 18:21:56 -0700 (PDT) Date: Mon, 3 Apr 2023 06:21:53 +0500 From: Khadija Kamran To: Ira Weiny Cc: outreachy@lists.linux.dev, hvaibhav.linux@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Alison Schofield Subject: Re: [PATCH 1/2] staging: greybus: add a single exit path to arche_platform_wd_irq() Message-ID: References: <642a1fdcb2648_394c3829469@iweiny-mobl.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <642a1fdcb2648_394c3829469@iweiny-mobl.notmuch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 02, 2023 at 05:37:48PM -0700, Ira Weiny wrote: > Khadija Kamran wrote: > > arche_platform_wd_irq() function has two exit paths. To make the code > > more readable, use only one exit path. > > > > Suggested-by: Alison Schofield > > Reviewed-by: Ira Weiny > Okay, noted. Also, would it be okay to send a patch revision with the changes or should I wait for the feedback on Dan's comment. Here is a link to it: https://lore.kernel.org/outreachy/6ce8aa34-e600-4d6a-adad-ead8255342e5@kili.mountain/ Thank you! Regards, Khadija > > Signed-off-by: Khadija Kamran > > --- > > drivers/staging/greybus/arche-platform.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c > > index fcbd5f71eff2..a64c1af091b0 100644 > > --- a/drivers/staging/greybus/arche-platform.c > > +++ b/drivers/staging/greybus/arche-platform.c > > @@ -153,6 +153,7 @@ static irqreturn_t arche_platform_wd_irq_thread(int irq, void *devid) > > static irqreturn_t arche_platform_wd_irq(int irq, void *devid) > > { > > struct arche_platform_drvdata *arche_pdata = devid; > > + irqreturn_t rc = IRQ_HANDLED; > > unsigned long flags; > > > > spin_lock_irqsave(&arche_pdata->wake_lock, flags); > > @@ -180,9 +181,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) > > WD_STATE_COLDBOOT_START) { > > arche_platform_set_wake_detect_state(arche_pdata, > > WD_STATE_COLDBOOT_TRIG); > > - spin_unlock_irqrestore(&arche_pdata->wake_lock, > > - flags); > > - return IRQ_WAKE_THREAD; > > + rc = IRQ_WAKE_THREAD; > > } > > } > > } > > @@ -204,7 +203,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid) > > > > spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); > > > > - return IRQ_HANDLED; > > + return rc; > > } > > > > /* > > -- > > 2.34.1 > > > > > >