From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36B6C76196 for ; Mon, 3 Apr 2023 16:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbjDCQX5 (ORCPT ); Mon, 3 Apr 2023 12:23:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232369AbjDCQXr (ORCPT ); Mon, 3 Apr 2023 12:23:47 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3837E9 for ; Mon, 3 Apr 2023 09:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680539026; x=1712075026; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=KKOoqArtLJbI+AYxzGdM3VB9YLMZqitlFjI+Y4NeHVM=; b=kt7fVBcy39DnmNJpFb1OqiO0Js52CHdNLZL03ykZfSfd2KjjlLHmDetx lnOOub/WJG8xHl/jGj01VWbe4gkytQuggND5xTDlVgKK2eeysPaUTCmXh Z9eweTA5l2xOLf+Qu8Fkw3kYHMZdxTWr9bDv8Tj8qKdtiLam0ptveI1CI /nO9GgguG9reYwAPMPkOU+kVCmUQ3AYhiBvVxLSW2UVQAqUBppyRNrBOA bYRIyvxk+Tr8fLykBsb7mebtlwu4pcgUw/n1F8MpBc9RfwEy8o/VQAq3v za0aZSzEsUFTKyqHm0620pFB9hMRHh6EhtEQAgv0ovSBivHqdhauSYOX/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="340677125" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="340677125" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 09:23:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="829622393" X-IronPort-AV: E=Sophos;i="5.98,315,1673942400"; d="scan'208";a="829622393" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.70]) by fmsmga001.fm.intel.com with SMTP; 03 Apr 2023 09:23:43 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 03 Apr 2023 19:23:43 +0300 Date: Mon, 3 Apr 2023 19:23:42 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Rob Clark , Thomas Zimmermann , open list Subject: Re: [PATCH] drm/vblank: Simplify drm_dev_has_vblank() Message-ID: References: <20230403160735.1211468-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230403160735.1211468-1-robdclark@gmail.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2023 at 09:07:35AM -0700, Rob Clark wrote: > From: Rob Clark > > What does vblank have to do with num_crtcs? Well, this was technically > correct, but you'd have to go look at where num_crtcs is initialized to > understand why. Lets just replace it with the simpler and more obvious > check. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/drm_vblank.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c > index 877e2067534f..ad34c235d853 100644 > --- a/drivers/gpu/drm/drm_vblank.c > +++ b/drivers/gpu/drm/drm_vblank.c > @@ -575,7 +575,7 @@ EXPORT_SYMBOL(drm_vblank_init); > */ > bool drm_dev_has_vblank(const struct drm_device *dev) > { > - return dev->num_crtcs != 0; > + return !!dev->vblank; The compiler knows how to turn things into a boolean. Or I guess if we want to be a bit more explicit we could write this as return dev->vblank != NULL; but IIRC that will make checkpatch complain because of someone's personal taste. > } > EXPORT_SYMBOL(drm_dev_has_vblank); > > -- > 2.39.2 -- Ville Syrjälä Intel