From: Thierry Reding <thierry.reding@gmail.com>
To: Haotien Hsu <haotienh@nvidia.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, JC Kuo <jckuo@nvidia.com>,
Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH v5] usb: xhci: tegra: fix sleep in atomic call
Date: Tue, 4 Apr 2023 14:36:39 +0200 [thread overview]
Message-ID: <ZCwZ169Ix7R4aPbx@orome> (raw)
In-Reply-To: <20230327095548.1599470-1-haotienh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2322 bytes --]
On Mon, Mar 27, 2023 at 05:55:48PM +0800, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
>
> When we set the dual-role port to Host mode, we observed the following
> splat:
> [ 167.057718] BUG: sleeping function called from invalid context at
> include/linux/sched/mm.h:229
> [ 167.057872] Workqueue: events tegra_xusb_usb_phy_work
> [ 167.057954] Call trace:
> [ 167.057962] dump_backtrace+0x0/0x210
> [ 167.057996] show_stack+0x30/0x50
> [ 167.058020] dump_stack_lvl+0x64/0x84
> [ 167.058065] dump_stack+0x14/0x34
> [ 167.058100] __might_resched+0x144/0x180
> [ 167.058140] __might_sleep+0x64/0xd0
> [ 167.058171] slab_pre_alloc_hook.constprop.0+0xa8/0x110
> [ 167.058202] __kmalloc_track_caller+0x74/0x2b0
> [ 167.058233] kvasprintf+0xa4/0x190
> [ 167.058261] kasprintf+0x58/0x90
> [ 167.058285] tegra_xusb_find_port_node.isra.0+0x58/0xd0
> [ 167.058334] tegra_xusb_find_port+0x38/0xa0
> [ 167.058380] tegra_xusb_padctl_get_usb3_companion+0x38/0xd0
> [ 167.058430] tegra_xhci_id_notify+0x8c/0x1e0
> [ 167.058473] notifier_call_chain+0x88/0x100
> [ 167.058506] atomic_notifier_call_chain+0x44/0x70
> [ 167.058537] tegra_xusb_usb_phy_work+0x60/0xd0
> [ 167.058581] process_one_work+0x1dc/0x4c0
> [ 167.058618] worker_thread+0x54/0x410
> [ 167.058650] kthread+0x188/0x1b0
> [ 167.058672] ret_from_fork+0x10/0x20
>
> The function tegra_xusb_padctl_get_usb3_companion eventually calls
> tegra_xusb_find_port and this in turn calls kasprintf which might sleep
> and so cannot be called from an atomic context.
>
> Fix this by moving the call to tegra_xusb_padctl_get_usb3_companion to
> the tegra_xhci_id_work function where it is really needed.
>
> Fixes: f836e7843036 ("usb: xhci-tegra: Add OTG support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
> V4 -> V5: Update commit message and code layout with 100 columns
> V3 -> V4: Remove copyright change from this patch
> V2 -> V3: Add version information
> V1 -> V2: Add "Fixes" and "Cc:" lines and update copyright years
> ---
> drivers/usb/host/xhci-tegra.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-04-04 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:55 [PATCH v5] usb: xhci: tegra: fix sleep in atomic call Haotien Hsu
2023-04-04 12:36 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCwZ169Ix7R4aPbx@orome \
--to=thierry.reding@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haotienh@nvidia.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox