From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A1BC6FD1D for ; Tue, 4 Apr 2023 18:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235763AbjDDSqs (ORCPT ); Tue, 4 Apr 2023 14:46:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235413AbjDDSqq (ORCPT ); Tue, 4 Apr 2023 14:46:46 -0400 Received: from out-32.mta0.migadu.com (out-32.mta0.migadu.com [IPv6:2001:41d0:1004:224b::20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F53A1BCE for ; Tue, 4 Apr 2023 11:46:44 -0700 (PDT) Date: Tue, 4 Apr 2023 18:46:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1680634002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6CCFZGbCbuQhOOVHvrtx2gWbSjOe3K33umxalnr28II=; b=iF+v2Q68XT8lGFaQ4gn2l9SacXhFLr07nAJDyI5xvBIPSL79kEpsGE78SUdsCLk2SYEpOH gNbkgNenyyOrqioed/7OY2lIcm+le6m6u0QuxKJDhvHEj9Xw6GN6Ra+PNeP5zXqchAsBTF 60qSwNES7H8nO1iMtQr+iEogRX+FYxU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Raghavendra Rao Ananta Cc: Oliver Upton , Marc Zyngier , Ricardo Koller , Reiji Watanabe , James Morse , Alexandru Elisei , Suzuki K Poulose , Will Deacon , Paolo Bonzini , Catalin Marinas , Jing Zhang , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 3/7] KVM: arm64: Implement __kvm_tlb_flush_range_vmid_ipa() Message-ID: References: <20230206172340.2639971-1-rananta@google.com> <20230206172340.2639971-4-rananta@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2023 at 02:08:29PM -0700, Raghavendra Rao Ananta wrote: > On Wed, Mar 29, 2023 at 5:59 PM Oliver Upton wrote: > > > > On Mon, Feb 06, 2023 at 05:23:36PM +0000, Raghavendra Rao Ananta wrote: > > > Define __kvm_tlb_flush_range_vmid_ipa() (for VHE and nVHE) > > > > bikeshed: Personally, I find that range implies it takes an address as an > > argument already. Maybe just call it __kvm_tlb_flush_vmid_range() > > > Hmm, since TLBI instructions takes-in a variety of ranges, VA or IPA, > I just thought of extending the '_ipa' to make things clear. Moreover > it aligns with the existing __kvm_tlb_flush_vmid_ipa(). WDYT? Like I said, just a bikeshed and it seemed trivial to eliminate a token in the function name. FWIW, you're dealing in terms of the IPA space by definition, as a VMID identifies an IPA address space. Range-based invalidations by VA would instead take an ASID as the address space identifier. -- Thanks, Oliver