From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8255FC77B76 for ; Tue, 18 Apr 2023 13:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231423AbjDRNix (ORCPT ); Tue, 18 Apr 2023 09:38:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbjDRNit (ORCPT ); Tue, 18 Apr 2023 09:38:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12774210B for ; Tue, 18 Apr 2023 06:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681825085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZAhC7ZdJaysYGSfjJpbZBcTrJMmolepzxRQWBXZQBkM=; b=KYssPd9kysup6haKoqzP79v3x6s9gZiDFeLay15JY2WtR+zLtwyHPbzOTgcwYXi0ksgGfJ rls1/C9t2gfxfCf0kvDctyr7rjq5oUm1/+3OYEHmB6+rLBrmkCoDKvcPS3jEoD3a2JEOVE y22jUvqKiYSvU6XbQPXlQeIYgP0g/so= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-uogvASBoMy6Bt2F177zYCw-1; Tue, 18 Apr 2023 09:38:04 -0400 X-MC-Unique: uogvASBoMy6Bt2F177zYCw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-2f69e5def13so780650f8f.0 for ; Tue, 18 Apr 2023 06:38:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681825083; x=1684417083; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAhC7ZdJaysYGSfjJpbZBcTrJMmolepzxRQWBXZQBkM=; b=Lc1Fj4iXFYstJgU2n4MPe9gCTvTz/P4z0s2PHPgY/PHdxuXK5DaLdgDE7UHm0HRX8D 5iHu9JEkklUpS4goIL/wlNePKpxg4Pdy4rIMdHiOrvm2OMt8fdUGuBhIjkuQIwbBi2oQ ML7WaNjVhfc+0AxW8rC0TwEEkuYwxyqTdfsPv2BpP0OTXR24NF/UqPA4OUAVlLY6IjNu 3OM6tgltblPMCFKSQ0NRY9lvThrZ2nM4OPZRQITr0kJymeqe4KsT70i/HZ9+cCjw/ibY qT6A45l94XmZsRGYfqaLuIYMgSA7SpkcqPWvMhd13zoUY7LCspZEZruCWk9jILra9AQb Kbfw== X-Gm-Message-State: AAQBX9cvLSBbvuv6t2DeD78Lr2Hn6+74HuCnRoC4rcMcpFaNpSGWrhP5 jViwYJSBnT9bcgtuT5FIfk5beNEw9f5EruwCaZqMmJ+0jvNtUh/jOZjKfrGn1VE9BJMEpAXsNg6 fVIVkBBFcrcP6+Qo9vkJdEu9s X-Received: by 2002:a5d:5141:0:b0:2fb:cbdf:fb48 with SMTP id u1-20020a5d5141000000b002fbcbdffb48mr1808074wrt.3.1681825083588; Tue, 18 Apr 2023 06:38:03 -0700 (PDT) X-Google-Smtp-Source: AKy350aPtx6JemOL/ZAUA3CSIMFOXAwPyuMbBNOjlwcnlcNO3RvB3f+yLM18m91J8i9J7QgrGjtT5w== X-Received: by 2002:a5d:5141:0:b0:2fb:cbdf:fb48 with SMTP id u1-20020a5d5141000000b002fbcbdffb48mr1808055wrt.3.1681825083281; Tue, 18 Apr 2023 06:38:03 -0700 (PDT) Received: from debian ([92.62.32.42]) by smtp.gmail.com with ESMTPSA id a8-20020a5d4568000000b002f61f08a9a6sm12769154wrc.50.2023.04.18.06.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 06:38:02 -0700 (PDT) Date: Tue, 18 Apr 2023 15:38:00 +0200 From: Guillaume Nault To: Samuel Thibault , James Chapman , tparkin@katalix.com, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PPPoL2TP: Add more code snippets Message-ID: References: <20230416220704.xqk4q6uwjbujnqpv@begin> <20230418085323.h6xij7w6d2o4kxxi@begin> <20230418091148.hh3b52zceacduex6@begin> <20230418103140.cps6csryl2xhrazz@begin> <20230418115409.aqsqi6pa4s4nhwgs@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230418115409.aqsqi6pa4s4nhwgs@begin> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 01:54:09PM +0200, Samuel Thibault wrote: > Guillaume Nault, le mar. 18 avril 2023 13:25:38 +0200, a ecrit: > > As I said in my previous reply, a simple L2TP example that goes until PPP > > channel and unit creation is fine. But any more advanced use of the PPP > > API should be documented in the PPP documentation. > > When it's really advanced, yes. But here it's just about tunnel > bridging, which is a very common L2TP thing to do. I can't undestand why you absolutely want this covered in l2tp.rst. This feature also works on PPPoE. Also, it's probably a desirable feature, but certainly not a common thing on Linux. This interface was added a bit more than 2 years ago, which is really recent considering the age of the code. Appart from maybe go-l2tp, I don't know of any user. > > I mean, these files document the API of their corresponding modules, > > their scope should be limitted to that (the PPP and L2TP layers are > > really different). > > I wouldn't call > > + ret = ioctl(ppp_chan_fd, PPPIOCBRIDGECHAN, &chindx2); > + close(ppp_chan_fd); > + if (ret < 0) > + return -errno; > > documentation... The documentation is in ppp_generic.rst. Does it really make sense to you to have the doc there and the sample code in l2tp.rst? Anyway, I'm not going to argue any longer. You have my opinion. You're always free to ignore feedbacks. > > That shouldn't preclude anyone from describing how to combine L2TP, PPP > > and others to cover more advanced use cases. It's just better done in a > > different file. > > A more complete example, yes. I don't plan on taking time to do it. > > Samuel >