Re: [PATCH v4] vfio/cdx: add support for CDX bus

Jason Gunthorpe
2023-04-19T00:06:57Z

On Tue, Apr 18, 2023 at 02:40:20PM -0600, Alex Williamson wrote:
> On Tue, 18 Apr 2023 12:50:13 +0000
> "Gupta, Nipun" <Nipun.Gupta@amd.com> wrote:
>
> > > -----Original Message-----
> > > From: Jason Gunthorpe <jgg@ziepe.ca>
> > > Sent: Tuesday, April 18, 2023 5:40 PM
> > > To: Gupta, Nipun <Nipun.Gupta@amd.com>
> > > Cc: alex.williamson@redhat.com; linux-kernel@vger.kernel.org;
> > > kvm@vger.kernel.org; masahiroy@kernel.org; nathan@kernel.org;
> > > ndesaulniers@google.com; nicolas@fjasle.eu; git (AMD-Xilinx) <git@amd.com>;
> > > Anand, Harpreet <harpreet.anand@amd.com>; Jansen Van Vuuren, Pieter
> > > <pieter.jansen-van-vuuren@amd.com>; Agarwal, Nikhil
> > > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>
> > > Subject: Re: [PATCH v4] vfio/cdx: add support for CDX bus
> > >
> > > Caution: This message originated from an External Source. Use proper caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Tue, Apr 18, 2023 at 05:06:55PM +0530, Nipun Gupta wrote:
> > >
> > > > diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig
> > > > index 89e06c981e43..aba36f5be4ec 100644
> > > > --- a/drivers/vfio/Kconfig
> > > > +++ b/drivers/vfio/Kconfig
> > > > @@ -57,6 +57,7 @@ source "drivers/vfio/pci/Kconfig"
> > > > source "drivers/vfio/platform/Kconfig"
> > > > source "drivers/vfio/mdev/Kconfig"
> > > > source "drivers/vfio/fsl-mc/Kconfig"
> > > > +source "drivers/vfio/cdx/Kconfig"
> > >
> > > keep sorted
> >
> > Since it is not sorted as of now, should a separate patch to be created for
> > sorting, before adding vfio-cdx?
>
> These are essentially in chronological order rather than alphabetical,
> so I don't really understand this request from Jason. Perhaps if it
> was already alphabetical the request would be justified, but I don't
> see any obligation here.

Ah, well knee jerk, I keep sorting these things, guess I haven't go
here yet.

Best practice is to sort lists like this.

Jason