From: Nick Desaulniers <ndesaulniers@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhen Lei <thunder.leizhen@huawei.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/8] scripts/kallsyms: remove redundant code for omitting U and N
Date: Fri, 7 Apr 2023 11:53:48 -0700 [thread overview]
Message-ID: <ZDBmvJh46Z+k05PR@google.com> (raw)
In-Reply-To: <20230308115243.82592-1-masahiroy@kernel.org>
On Wed, Mar 08, 2023 at 08:52:36PM +0900, Masahiro Yamada wrote:
> The symbol types 'U' and 'N' are already filtered out by the following
> line in scripts/mksysmap:
>
> -e ' [aNUw] '
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>
> scripts/kallsyms.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index ea1e3d3aaa6b..8148e880f78e 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -178,10 +178,7 @@ static bool is_ignored_symbol(const char *name, char type)
> return true;
> }
>
> - if (type == 'U' || type == 'u')
> - return true;
> - /* exclude debugging symbols */
> - if (type == 'N' || type == 'n')
> + if (type == 'u' || type == 'n')
> return true;
>
> if (toupper(type) == 'A') {
> --
> 2.34.1
>
>
prev parent reply other threads:[~2023-04-07 18:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 11:52 [PATCH 1/8] scripts/kallsyms: remove redundant code for omitting U and N Masahiro Yamada
2023-03-08 11:52 ` [PATCH 2/8] scripts/mksysmap: remove comments described in nm(1) Masahiro Yamada
2023-04-07 18:46 ` Nick Desaulniers
2023-04-10 9:38 ` Masahiro Yamada
2023-03-08 11:52 ` [PATCH 3/8] scripts/mksysmap: use sed with in-line comments Masahiro Yamada
2023-04-07 18:59 ` Nick Desaulniers
2023-04-07 19:01 ` Nick Desaulniers
2023-04-08 15:01 ` Masahiro Yamada
2023-04-08 14:29 ` Masahiro Yamada
2023-04-10 9:38 ` Masahiro Yamada
2023-03-08 11:52 ` [PATCH 4/8] scripts/kallsyms: exclude symbols generated by itself dynamically Masahiro Yamada
2023-04-07 20:12 ` Nick Desaulniers
2023-04-10 9:38 ` Masahiro Yamada
2023-03-08 11:52 ` [PATCH 5/8] scripts/kallsyms: move compiler-generated symbol patterns to mksysmap Masahiro Yamada
2023-04-07 20:16 ` Nick Desaulniers
2023-03-08 11:52 ` [PATCH 6/8] scripts/kallsyms: change the output order Masahiro Yamada
2023-03-08 11:52 ` [PATCH 7/8] scripts/kallsyms: decrease expand_symbol() / cleanup_symbol_name() calls Masahiro Yamada
2023-03-08 11:52 ` [PATCH 8/8] scripts/kallsyms: update the usage in the comment block Masahiro Yamada
2023-04-07 20:25 ` Nick Desaulniers
2023-04-07 18:53 ` Nick Desaulniers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDBmvJh46Z+k05PR@google.com \
--to=ndesaulniers@google.com \
--cc=arnd@arndb.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).