Re: [net PATCH v2 3/7] octeontx2-af: Add validation for lmac type

Simon Horman
2023-04-08T14:42:56Z

On Fri, Apr 07, 2023 at 05:53:40PM +0530, Sai Krishna wrote:
> From: Hariprasad Kelam <hkelam@marvell.com>
>
> Upon physical link change, firmware reports to the kernel about the
> change along with the details like speed, lmac_type_id, etc.
> Kernel derives lmac_type based on lmac_type_id received from firmware.
>
> In a few scenarios, firmware returns an invalid lmac_type_id, which
> is resulting in below kernel panic. This patch adds the missing
> validation of the lmac_type_id field.
>
> Internal error: Oops: 96000005 [#1] PREEMPT SMP
> [ 35.321595] Modules linked in:
> [ 35.328982] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted
> 5.4.210-g2e3169d8e1bc-dirty #17
> [ 35.337014] Hardware name: Marvell CN103XX board (DT)
> [ 35.344297] Workqueue: events work_for_cpu_fn
> [ 35.352730] pstate: 40400089 (nZcv daIf +PAN -UAO)
> [ 35.360267] pc : strncpy+0x10/0x30
> [ 35.366595] lr : cgx_link_change_handler+0x90/0x180
>
> Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to PFs")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
>
> drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

Reviewed-by: Simon Horman <simon.horman@corigine.com>