* drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size
@ 2023-03-23 1:25 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-03-23 1:25 UTC (permalink / raw)
To: Mark Rutland; +Cc: oe-kbuild-all, linux-kernel, Catalin Marinas
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fff5a5e7f528b2ed2c335991399a766c2cf01103
commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
date: 8 weeks ago
config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230323/202303230903.Wi6Knuqq-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303230903.Wi6Knuqq-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
>> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/strncpy +60 drivers/acpi/acpica/tbfind.c
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 16
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 17 /*******************************************************************************
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 18 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 19 * FUNCTION: acpi_tb_find_table
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 20 *
ba494beeaa69bc drivers/acpi/acpica/tbfind.c Bob Moore 2012-07-12 21 * PARAMETERS: signature - String with ACPI table signature
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 22 * oem_id - String with the table OEM ID
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 23 * oem_table_id - String with the OEM Table ID
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 24 * table_index - Where the table index is returned
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 25 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 26 * RETURN: Status and table index
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 27 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 28 * DESCRIPTION: Find an ACPI table (in the RSDT/XSDT) that matches the
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 29 * Signature, OEM ID and OEM Table ID. Returns an index that can
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 30 * be used to get the table header or entire table.
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 31 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 32 ******************************************************************************/
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 33 acpi_status
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 34 acpi_tb_find_table(char *signature,
67a119f990063f drivers/acpi/tables/tbfind.c Bob Moore 2008-06-10 35 char *oem_id, char *oem_table_id, u32 *table_index)
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 36 {
ac0f06ebb815da drivers/acpi/acpica/tbfind.c Lv Zheng 2016-09-07 37 acpi_status status = AE_OK;
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 38 struct acpi_table_header header;
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 39 u32 i;
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 40
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 41 ACPI_FUNCTION_TRACE(tb_find_table);
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 42
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 43 /* Validate the input table signature */
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 44
6a0df32c22fdfc drivers/acpi/acpica/tbfind.c Bob Moore 2016-05-05 45 if (!acpi_ut_valid_nameseg(signature)) {
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 46 return_ACPI_STATUS(AE_BAD_SIGNATURE);
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 47 }
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 48
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 49 /* Don't allow the OEM strings to be too long */
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 50
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 51 if ((strlen(oem_id) > ACPI_OEM_ID_SIZE) ||
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 52 (strlen(oem_table_id) > ACPI_OEM_TABLE_ID_SIZE)) {
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 53 return_ACPI_STATUS(AE_AML_STRING_LIMIT);
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 54 }
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 55
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 56 /* Normalize the input strings */
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 57
4fa4616e279df8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-07-01 58 memset(&header, 0, sizeof(struct acpi_table_header));
a3ce7a8e0dd9ba drivers/acpi/acpica/tbfind.c Bob Moore 2019-04-08 59 ACPI_COPY_NAMESEG(header.signature, signature);
4fa4616e279df8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-07-01 @60 strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
:::::: The code at line 60 was first introduced by commit
:::::: 4fa4616e279df89baeb36287bbee83ab272edaed ACPICA: De-macroize calls to standard C library functions
:::::: TO: Bob Moore <robert.moore@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size
@ 2023-04-07 7:02 kernel test robot
2023-04-11 11:13 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-04-07 7:02 UTC (permalink / raw)
To: Mark Rutland; +Cc: oe-kbuild-all, linux-kernel, Catalin Marinas
Hi Mark,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f2afccfefe7be1f7346564fe619277110d341f9b
commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
date: 2 months ago
config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230407/202304071552.CeeIBr5P-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304071552.CeeIBr5P-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
>> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/strncpy +60 drivers/acpi/acpica/tbfind.c
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 16
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 17 /*******************************************************************************
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 18 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 19 * FUNCTION: acpi_tb_find_table
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 20 *
ba494beeaa69bc drivers/acpi/acpica/tbfind.c Bob Moore 2012-07-12 21 * PARAMETERS: signature - String with ACPI table signature
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 22 * oem_id - String with the table OEM ID
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 23 * oem_table_id - String with the OEM Table ID
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 24 * table_index - Where the table index is returned
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 25 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 26 * RETURN: Status and table index
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 27 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 28 * DESCRIPTION: Find an ACPI table (in the RSDT/XSDT) that matches the
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 29 * Signature, OEM ID and OEM Table ID. Returns an index that can
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 30 * be used to get the table header or entire table.
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 31 *
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 32 ******************************************************************************/
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 33 acpi_status
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 34 acpi_tb_find_table(char *signature,
67a119f990063f drivers/acpi/tables/tbfind.c Bob Moore 2008-06-10 35 char *oem_id, char *oem_table_id, u32 *table_index)
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 36 {
ac0f06ebb815da drivers/acpi/acpica/tbfind.c Lv Zheng 2016-09-07 37 acpi_status status = AE_OK;
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 38 struct acpi_table_header header;
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 39 u32 i;
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 40
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 41 ACPI_FUNCTION_TRACE(tb_find_table);
f3d2e7865c8162 drivers/acpi/tables/tbfind.c Bob Moore 2007-02-02 42
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 43 /* Validate the input table signature */
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 44
6a0df32c22fdfc drivers/acpi/acpica/tbfind.c Bob Moore 2016-05-05 45 if (!acpi_ut_valid_nameseg(signature)) {
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 46 return_ACPI_STATUS(AE_BAD_SIGNATURE);
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 47 }
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 48
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 49 /* Don't allow the OEM strings to be too long */
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 50
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 51 if ((strlen(oem_id) > ACPI_OEM_ID_SIZE) ||
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 52 (strlen(oem_table_id) > ACPI_OEM_TABLE_ID_SIZE)) {
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 53 return_ACPI_STATUS(AE_AML_STRING_LIMIT);
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 54 }
9f41fd8a175ff8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-08-25 55
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 56 /* Normalize the input strings */
47c08729bf1c60 drivers/acpi/tables/tbfind.c Lin Ming 2008-04-10 57
4fa4616e279df8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-07-01 58 memset(&header, 0, sizeof(struct acpi_table_header));
a3ce7a8e0dd9ba drivers/acpi/acpica/tbfind.c Bob Moore 2019-04-08 59 ACPI_COPY_NAMESEG(header.signature, signature);
4fa4616e279df8 drivers/acpi/acpica/tbfind.c Bob Moore 2015-07-01 @60 strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
:::::: The code at line 60 was first introduced by commit
:::::: 4fa4616e279df89baeb36287bbee83ab272edaed ACPICA: De-macroize calls to standard C library functions
:::::: TO: Bob Moore <robert.moore@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size
2023-04-07 7:02 drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size kernel test robot
@ 2023-04-11 11:13 ` Catalin Marinas
2023-04-13 1:54 ` Yujie Liu
0 siblings, 1 reply; 4+ messages in thread
From: Catalin Marinas @ 2023-04-11 11:13 UTC (permalink / raw)
To: kernel test robot; +Cc: Mark Rutland, oe-kbuild-all, linux-kernel, linux-acpi
On Fri, Apr 07, 2023 at 03:02:15PM +0800, kernel test robot wrote:
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: f2afccfefe7be1f7346564fe619277110d341f9b
> commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
> date: 2 months ago
> config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230407/202304071552.CeeIBr5P-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 olddefconfig
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304071552.CeeIBr5P-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
> >> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
> 60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
> 61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
I think the kernel test robot should filter out any reports related to
this commit. The warning has nothing to do with the -O2 vs -Os change.
It's simply that the compiler now warns if strncpy() has the destination
size equal to the bound parameter (for some reason it doesn't do this
with -Os). I mentioned it on a different report here:
https://lore.kernel.org/all/Y%2FdM77YdzDKRDdj1@arm.com/
A potential solution to silence the compiler is to go through the ACPI
code and change those strncpy() instances to memcpy(). I don't think
those strings are even null-terminated in the APCI spec, so using
strncpy() doesn't make sense.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size
2023-04-11 11:13 ` Catalin Marinas
@ 2023-04-13 1:54 ` Yujie Liu
0 siblings, 0 replies; 4+ messages in thread
From: Yujie Liu @ 2023-04-13 1:54 UTC (permalink / raw)
To: Catalin Marinas
Cc: kernel test robot, Mark Rutland, oe-kbuild-all, linux-kernel,
linux-acpi
On Tue, Apr 11, 2023 at 12:13:55PM +0100, Catalin Marinas wrote:
> On Fri, Apr 07, 2023 at 03:02:15PM +0800, kernel test robot wrote:
> > FYI, the error/warning still remains.
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: f2afccfefe7be1f7346564fe619277110d341f9b
> > commit: 8f9e0a52810dd83406c768972d022c37e7a18f1f ACPI: Don't build ACPICA with '-Os'
> > date: 2 months ago
> > config: x86_64-sof-customedconfig-fuzz-defconfig (https://download.01.org/0day-ci/archive/20230407/202304071552.CeeIBr5P-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > reproduce (this is a W=1 build):
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f9e0a52810dd83406c768972d022c37e7a18f1f
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 8f9e0a52810dd83406c768972d022c37e7a18f1f
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > make W=1 O=build_dir ARCH=x86_64 olddefconfig
> > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202304071552.CeeIBr5P-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table':
> > >> drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation]
> > 60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation]
> > 61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
>
> I think the kernel test robot should filter out any reports related to
> this commit. The warning has nothing to do with the -O2 vs -Os change.
> It's simply that the compiler now warns if strncpy() has the destination
> size equal to the bound parameter (for some reason it doesn't do this
> with -Os). I mentioned it on a different report here:
>
> https://lore.kernel.org/all/Y%2FdM77YdzDKRDdj1@arm.com/
>
> A potential solution to silence the compiler is to go through the ACPI
> code and change those strncpy() instances to memcpy(). I don't think
> those strings are even null-terminated in the APCI spec, so using
> strncpy() doesn't make sense.
Sorry for making this noise. We've configured the robot to filter out
the reports related to this commit.
--
Best Regards,
Yujie
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-13 1:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 7:02 drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size kernel test robot
2023-04-11 11:13 ` Catalin Marinas
2023-04-13 1:54 ` Yujie Liu
-- strict thread matches above, loose matches on Subject: below --
2023-03-23 1:25 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox