From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12B7C77B6F for ; Tue, 11 Apr 2023 11:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229981AbjDKLnL (ORCPT ); Tue, 11 Apr 2023 07:43:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjDKLnA (ORCPT ); Tue, 11 Apr 2023 07:43:00 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D0964234 for ; Tue, 11 Apr 2023 04:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213376; x=1712749376; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MmgttL6Z2ite1qRkYYnR8yRMQm4E4KBl2+ANiydF4NE=; b=hYdUuSSYYzJtZwIPbcB6StX6XTvxxB9FKbZOj/5SIkr23EQSJnn+RkrD SKbOddUah1oGGuPYXj1Ej34VbK+eeVlAGOgD4OzmqSqMfMOuLB/UH+nzc KG4kkNVSOTXhsjJKmPQ5NpROpc6A4iiVdGG7Yy8ixRL38qHxqDIXUsTHu 7Rw5XpfgC8OTwg61wpNseqnXFPValzSdDuGwGNH42VJCfY+RkvffE5TLp ZHiqArblvkVv73kNofTCRmGt+qxs7w0ichOA2WdXhshKJ82rx1oz1iWyS ckD0HFqQejjO1LFBu6kxRc+iEhi9bU8yGWh9OFnrj/3U8dFihvVqel+Lm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="341085905" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="341085905" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:42:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="721175700" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="721175700" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2023 04:42:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pmCOZ-00FFDR-2f; Tue, 11 Apr 2023 14:42:43 +0300 Date: Tue, 11 Apr 2023 14:42:43 +0300 From: Andy Shevchenko To: Chanwoo Choi Cc: Chanwoo Choi , linux-kernel@vger.kernel.org, MyungJoo Ham Subject: Re: [PATCH v2 2/5] extcon: Get rid of not really used name field in struct extcon_dev Message-ID: References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> <20230405152745.24959-3-andriy.shevchenko@linux.intel.com> <4632ce69-2a94-0c33-9a76-b97596436e24@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4632ce69-2a94-0c33-9a76-b97596436e24@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2023 at 04:26:35AM +0900, Chanwoo Choi wrote: > On 23. 4. 6. 00:27, Andy Shevchenko wrote: ... > > - if (IS_ERR_OR_NULL(edev->name)) { > > - dev_err(&edev->dev, > > - "extcon device name is null\n"); > > - return -EINVAL; > > - } JFYI: this is a dead code in case you want to clean it up. Since the patch is NAKed, I'm not going to split it. Hence just for your information. -- With Best Regards, Andy Shevchenko