From: William Breathitt Gray <william.gray@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio
Date: Tue, 11 Apr 2023 14:36:23 -0400 [thread overview]
Message-ID: <ZDWopwozNjFg/9NX@fedora> (raw)
In-Reply-To: <571b4df1-91ea-481c-9797-842974dfa922@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On Tue, Apr 11, 2023 at 09:23:55PM +0100, Mark Brown wrote:
> On Mon, Mar 20, 2023 at 10:50:15AM -0400, William Breathitt Gray wrote:
> > A private data structure struct dio48e_gpio is introduced to facilitate
> > passage of the regmap and IRQ mask state for the device to the callback
> > dio48e_handle_mask_sync(). This is in preparation for the removal of the
> > handle_mask_sync() map parameter in a subsequent patch.
>
> What's the story with this patch?
Currently dio48e_handle_mask_sync() uses the map argument in its
implementation. Once the map parameter is removed, the current
implementation of dio48e_handle_mask_sync() will no longer build, so we
must adjust the implementation to no longer depend on map.
The reason for this particular patch is to keep the reimplementation of
dio48e_handle_mask_sync() separate so that the handle_mask_sync() map
parameter removal patch is simple. This keeps the git history clear
and allows us to address any possible regressions to 104-dio-48e
separately without affecting the handle_mask_sync() API.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-11 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 14:50 [PATCH v3 0/2] Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-03-20 14:50 ` [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio William Breathitt Gray
2023-04-07 11:47 ` [RESEND PATCH " William Breathitt Gray
2023-04-11 20:23 ` [PATCH " Mark Brown
2023-04-11 18:36 ` William Breathitt Gray [this message]
2023-04-11 21:15 ` Mark Brown
2023-04-11 21:35 ` William Breathitt Gray
2023-04-21 8:20 ` Linus Walleij
2023-03-20 14:50 ` [PATCH v3 2/2] regmap-irq: Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-04-07 11:47 ` [RESEND PATCH " William Breathitt Gray
2023-03-20 15:32 ` [PATCH v3 0/2] " Andy Shevchenko
2023-03-22 16:55 ` Bartosz Golaszewski
2023-04-07 11:47 ` [RESEND PATCH " William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDWopwozNjFg/9NX@fedora \
--to=william.gray@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox