From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89784C77B76 for ; Wed, 12 Apr 2023 20:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230241AbjDLUaK (ORCPT ); Wed, 12 Apr 2023 16:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbjDLUaE (ORCPT ); Wed, 12 Apr 2023 16:30:04 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DBFB76B2 for ; Wed, 12 Apr 2023 13:29:55 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id h24-20020a17090a9c1800b002404be7920aso12890314pjp.5 for ; Wed, 12 Apr 2023 13:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681331395; x=1683923395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MPIZuP0MZByRyC+/nU9qhHjtfr1zaG8eGgVe3FKVcpE=; b=4i1ZGWC7T0vcawyANuqheZxC4oYpBwN5406UaN8TmvzhIkKY1UYMwB5AqBeg95Q6GM S1UvZvmMB505K6ozQ2XtKaplTM/0klq52c430fSTqKBOONVXzpVOEIxiGPbl5DHCjzzp Mg1TO0DaLWiULgIhhPHBLXpfTquxUtgxOjikd1FpVrUYwAmdTEt1xE+CEY/HqwDybLZV kj01pGMvuC3zgWQ3FW9tjp1woTn24MteocGWzJkZb+4hp6ViZo1mSMOwhq3HD1Dict86 MzwjpBrVWBojdTL2ZHnpXY4RDOFRTYh2/IhZGgvyNDiljfX7psrugiJxafIzLMYucoeA mgaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681331395; x=1683923395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MPIZuP0MZByRyC+/nU9qhHjtfr1zaG8eGgVe3FKVcpE=; b=DfFd4MDUAF8eR2OVHnRI5Q9i5TYubZnDVRa1a3MgUg58ZMARTQdV00Bxf3EVz+T8+w +3QW41HjhOGR/Rwy8u8VQzDFfJI5VxMa7wTrTsIWi/itJMcukUdNsNyXNX86V43Yqzri +H6YxbgaJG2IYbvbYTnrDjxf8kh4vXiy2MiSTq96sXVvR3VyfsgVl/XNCkD4vUl4ZHgF TpS1Xt0oz2r3R0GQUapClcQtE5pamCDvyZFt+YeYSvUzxfqTYt4snW8IG9DQ8khT0r5s MdSTFxZl+ABv+z/FPT3kO4shDq28DMRhlQBpOUHbulIkadFNCoVSMvO7XbW2hNoq0kVE dJMA== X-Gm-Message-State: AAQBX9e6jcSLqWR9r3uEu2BGawljSd173hVzrJqSLXwoU2YCKMdzQv5T mU/M3nKfxQojMYwx6zdKPQbK9ooaoqZUtHTyl0pmpw== X-Google-Smtp-Source: AKy350YrZ02ScWTgT8jhEbD53S2CWz6oXdOXMzAXXLbV3fv9KVIYZsKPbbGjmkiIUKkubXaaP3P2VQ== X-Received: by 2002:a17:902:e749:b0:1a6:6b9c:48ae with SMTP id p9-20020a170902e74900b001a66b9c48aemr67912plf.52.1681331395062; Wed, 12 Apr 2023 13:29:55 -0700 (PDT) Received: from google.com ([2620:15c:2d1:203:4a4a:51a1:19b:61ab]) by smtp.gmail.com with ESMTPSA id g24-20020a63e618000000b00502f20aa4desm4115pgh.70.2023.04.12.13.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 13:29:54 -0700 (PDT) Date: Wed, 12 Apr 2023 13:29:49 -0700 From: Nick Desaulniers To: Josh Poimboeuf , "Borislav Petkov (AMD)" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Miroslav Benes , linux-btrfs@vger.kernel.org, Mark Rutland , linux-scsi@vger.kernel.org, linux-hyperv@vger.kernel.org, Arnd Bergmann , "Guilherme G . Piccoli" , Michael Kelley , kernel test robot Subject: Re: [PATCH 02/11] init: Mark start_kernel() __noreturn Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2023 at 05:09:55PM -0700, Josh Poimboeuf wrote: > Fixes the following warning: > > vmlinux.o: warning: objtool: x86_64_start_reservations+0x28: unreachable instruction > > Reported-by: kernel test robot > Link: https://lore.kernel.org/r/202302161142.K3ziREaj-lkp@intel.com/ > Signed-off-by: Josh Poimboeuf Ah, I just realized that my series will conflict with this. https://lore.kernel.org/llvm/20230412-no_stackp-v1-1-46a69b507a4b@google.com/ Perhaps if my series gets positive feedback; I can rebase it on top of this and it can become part of your series? For this patch, Reviewed-by: Nick Desaulniers Though I'm curious, it does look like it's necessary because of 01/11 in the series? Any idea how the 0day bot report happened before 1/11 existed? (Surely gcc isn't assuming a weak function is implicitly noreturn and make optimizations based on that (that's one hazard I'm worried about)?) It looks like perhaps the link to https://lore.kernel.org/all/202302161142.K3ziREaj-lkp@intel.com/ on 2/11 was 0day testing the arch-cpu-idle-dead-noreturn branch of your kernel tree https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=arch-cpu-idle-dead-noreturn , which had 1/11 in it, IIUC? Perhaps this link should go on 1/11 rather than 2/11? Looking back at 1/11, 3/11, 8/11 I noticed not all patches have links to 0day reports. Are you able to flesh out more info how/what/when such objtool warnings are observed? Are the warnings ever results of patches earlier in the series?