From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1146C77B61 for ; Thu, 13 Apr 2023 14:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjDMOam (ORCPT ); Thu, 13 Apr 2023 10:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbjDMOak (ORCPT ); Thu, 13 Apr 2023 10:30:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 577CE1BEA for ; Thu, 13 Apr 2023 07:30:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD30B609FA for ; Thu, 13 Apr 2023 14:30:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB1B0C433D2; Thu, 13 Apr 2023 14:30:36 +0000 (UTC) Date: Thu, 13 Apr 2023 15:30:33 +0100 From: Catalin Marinas To: Baoquan He Cc: linux-kernel@vger.kernel.org, horms@kernel.org, thunder.leizhen@huawei.com, John.p.donnelly@oracle.com, will@kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Message-ID: References: <20230407022419.19412-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 03:45:50PM +0800, Baoquan He wrote: > I am OK with this version, or the version with min(SZ_4G, > arm64_dma_phys_limit), or v4. Please help point out if I got your idea > correctly. Thanks a lot. I think we should stick to this patch. The disabling of the ZONE_DMA(32) is fairly specialised and you are right that we should not introduce an artificial 4GB crashkernel boundary on such systems. The slight confusion may be that ,high triggers a search above 4GB where there's not such boundary but this would match the documentation anyway. -- Catalin