From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F57C77B6E for ; Thu, 13 Apr 2023 15:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbjDMPy6 (ORCPT ); Thu, 13 Apr 2023 11:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbjDMPy4 (ORCPT ); Thu, 13 Apr 2023 11:54:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BD7B7EC2 for ; Thu, 13 Apr 2023 08:54:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB2626159E for ; Thu, 13 Apr 2023 15:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B3EFC433D2; Thu, 13 Apr 2023 15:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681401294; bh=o4ODpdXxs0R0RlNul9JlHgYE6YejXTJwLDkZoKzub5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D39YPG/eK4fIhVrODY+Le+B0dyr789mrvtJCpy+vKoGxzVZkazoyNu6+sSdHmFkk/ gCSWym3u1TpU068BaSVP7IYXo7/wm0wPV4pPALJZpx5zQXjRW2ouMvQxGVt/k6EECX vqw5HgbyK9SYCk0QLKnbOMxyeW+FbmTySwC1QvHr0C+YbCpqGdyQ0bwyFJVgQbWl1k z6WjsaXrXG4Kb971ww534tF/AlDGef2Yrm7c9o5lUCen4HUuFaIQviovTXhyCRecGq DxXHo2KTxWbP4Sh0NlrwZIxD5OPXLPd1W6I3QludiPFRurL6cqmzdQfZlUpVeO6TqY ZA6+6LUncmTbA== Date: Thu, 13 Apr 2023 08:54:52 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Yangtao Li , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: remove bulk remove_proc_entry() and unnecessary kobject_del() Message-ID: References: <20230406191629.63024-1-frank.li@vivo.com> <2e41d6e0-13bb-fa5d-00aa-75865b8e7c34@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e41d6e0-13bb-fa5d-00aa-75865b8e7c34@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/13, Chao Yu wrote: > On 2023/4/7 3:16, Yangtao Li wrote: > > Convert to use remove_proc_subtree() and kill kobject_del() directly. > > kobject_put() actually covers kobject removal automatically, which is > > single stage removal. > > > > Signed-off-by: Yangtao Li > > --- > > fs/f2fs/sysfs.c | 15 ++------------- > > 1 file changed, 2 insertions(+), 13 deletions(-) > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index dfbd17802549..3aad3500a701 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -1461,25 +1461,14 @@ int f2fs_register_sysfs(struct f2fs_sb_info *sbi) > > void f2fs_unregister_sysfs(struct f2fs_sb_info *sbi) > > { > > - if (sbi->s_proc) { > > -#ifdef CONFIG_F2FS_IOSTAT > > - remove_proc_entry("iostat_info", sbi->s_proc); > > -#endif > > - remove_proc_entry("segment_info", sbi->s_proc); > > - remove_proc_entry("segment_bits", sbi->s_proc); > > - remove_proc_entry("victim_bits", sbi->s_proc); > > - remove_proc_entry("discard_plist_info", sbi->s_proc); > > - remove_proc_entry(sbi->sb->s_id, f2fs_proc_root); > > - } > > + if (sbi->s_proc) > > + remove_proc_subtree(sbi->sb->s_id, f2fs_proc_root); > > - kobject_del(&sbi->s_stat_kobj); > > - f2fs_register_sysfs > - kobject_init_and_add(&sbi->s_stat_kobj, ..) > > /** > * kobject_init_and_add() - Initialize a kobject structure and add it to > * the kobject hierarchy. > ... > * > * This function combines the call to kobject_init() and kobject_add(). > ... > */ > > /** > * kobject_del() - Unlink kobject from hierarchy. > * @kobj: object. > * > * This is the function that should be called to delete an object > * successfully added via kobject_add(). > */ > > Am I missing something? kobject_put -> kobject_cleanup was supposed to do it? > > Thanks, > > > kobject_put(&sbi->s_stat_kobj); > > wait_for_completion(&sbi->s_stat_kobj_unregister); > > - kobject_del(&sbi->s_feature_list_kobj); > > kobject_put(&sbi->s_feature_list_kobj); > > wait_for_completion(&sbi->s_feature_list_kobj_unregister); > > - kobject_del(&sbi->s_kobj); > > kobject_put(&sbi->s_kobj); > > wait_for_completion(&sbi->s_kobj_unregister); > > }