Re: [PATCH v9 1/2 RESEND] dt-bindings: i2c: aspeed: support for AST2600-i2cv2

Krzysztof Kozlowski
2023-04-13T16:17:20Z

On 13/04/2023 09:53, Ryan Chen wrote:
> Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,enable-dma
> and description for ast2600-i2cv2.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>

> required:
> - reg
> - compatible
> @@ -57,6 +73,26 @@ required:
>
> unevaluatedProperties: false
>
> +allOf:

allOf goes before unevaluatedProperties. Use example-schema.yaml as your
template/guidance.

> + - $ref: /schemas/i2c/i2c-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: aspeed,ast2600-i2cv2
> +
> + then:
> + properties:
> + reg:
> + minItems: 2
> + required:
> + - aspeed,global-regs
> + else:
> + properties:
> + aspeed,global-regs: false
> + aspeed,enable-dma: false
> +
> +

Only one blank line.

Best regards,
Krzysztof