* [PATCH] net: wwan: Expose secondary AT port on DATA1
@ 2023-04-14 11:07 Jaime Breva via B4 Relay
2023-04-14 14:14 ` Stephan Gerhold
2023-04-14 14:56 ` Loic Poulain
0 siblings, 2 replies; 3+ messages in thread
From: Jaime Breva via B4 Relay @ 2023-04-14 11:07 UTC (permalink / raw)
To: Stephan Gerhold, Loic Poulain, Sergey Ryazanov, Johannes Berg,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-remoteproc, linux-kernel, Jaime Breva
From: Jaime Breva <jbreva@nayarsystems.com>
Our use-case needs two AT ports available:
One for running a ppp daemon, and another one for management
This patch enables a second AT port on DATA1
Signed-off-by: Jaime Breva <jbreva@nayarsystems.com>
---
drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c
index 31c24420ab2e..e964bdeea2b3 100644
--- a/drivers/net/wwan/rpmsg_wwan_ctrl.c
+++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c
@@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = {
/* RPMSG channels for Qualcomm SoCs with integrated modem */
{ .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI },
{ .name = "DATA4", .driver_data = WWAN_PORT_AT },
+ { .name = "DATA1", .driver_data = WWAN_PORT_AT },
{},
};
MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);
---
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a
Best regards,
--
Jaime Breva <jbreva@nayarsystems.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: wwan: Expose secondary AT port on DATA1
2023-04-14 11:07 [PATCH] net: wwan: Expose secondary AT port on DATA1 Jaime Breva via B4 Relay
@ 2023-04-14 14:14 ` Stephan Gerhold
2023-04-14 14:56 ` Loic Poulain
1 sibling, 0 replies; 3+ messages in thread
From: Stephan Gerhold @ 2023-04-14 14:14 UTC (permalink / raw)
To: jbreva
Cc: Loic Poulain, Sergey Ryazanov, Johannes Berg, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev,
linux-remoteproc, linux-kernel
On Fri, Apr 14, 2023 at 01:07:40PM +0200, Jaime Breva via B4 Relay wrote:
> From: Jaime Breva <jbreva@nayarsystems.com>
>
> Our use-case needs two AT ports available:
> One for running a ppp daemon, and another one for management
>
> This patch enables a second AT port on DATA1
>
> Signed-off-by: Jaime Breva <jbreva@nayarsystems.com>
Acked-by: Stephan Gerhold <stephan@gerhold.net>
Thanks,
Stephan
> ---
> drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> index 31c24420ab2e..e964bdeea2b3 100644
> --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c
> +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = {
> /* RPMSG channels for Qualcomm SoCs with integrated modem */
> { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI },
> { .name = "DATA4", .driver_data = WWAN_PORT_AT },
> + { .name = "DATA1", .driver_data = WWAN_PORT_AT },
> {},
> };
> MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);
>
> ---
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a
>
> Best regards,
> --
> Jaime Breva <jbreva@nayarsystems.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: wwan: Expose secondary AT port on DATA1
2023-04-14 11:07 [PATCH] net: wwan: Expose secondary AT port on DATA1 Jaime Breva via B4 Relay
2023-04-14 14:14 ` Stephan Gerhold
@ 2023-04-14 14:56 ` Loic Poulain
1 sibling, 0 replies; 3+ messages in thread
From: Loic Poulain @ 2023-04-14 14:56 UTC (permalink / raw)
To: jbreva
Cc: Stephan Gerhold, Sergey Ryazanov, Johannes Berg, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev,
linux-remoteproc, linux-kernel
Hello,
On Fri, 14 Apr 2023 at 13:09, Jaime Breva via B4 Relay
<devnull+jbreva.nayarsystems.com@kernel.org> wrote:
>
> From: Jaime Breva <jbreva@nayarsystems.com>
>
> Our use-case needs two AT ports available:
> One for running a ppp daemon, and another one for management
>
> This patch enables a second AT port on DATA1
>
> Signed-off-by: Jaime Breva <jbreva@nayarsystems.com>
> ---
Could you fix your subject prefix to be compliant with netdev list
[1], and also probably target net-next.
[1] https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Regards,
Loic
> drivers/net/wwan/rpmsg_wwan_ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wwan/rpmsg_wwan_ctrl.c b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> index 31c24420ab2e..e964bdeea2b3 100644
> --- a/drivers/net/wwan/rpmsg_wwan_ctrl.c
> +++ b/drivers/net/wwan/rpmsg_wwan_ctrl.c
> @@ -149,6 +149,7 @@ static const struct rpmsg_device_id rpmsg_wwan_ctrl_id_table[] = {
> /* RPMSG channels for Qualcomm SoCs with integrated modem */
> { .name = "DATA5_CNTL", .driver_data = WWAN_PORT_QMI },
> { .name = "DATA4", .driver_data = WWAN_PORT_AT },
> + { .name = "DATA1", .driver_data = WWAN_PORT_AT },
> {},
> };
> MODULE_DEVICE_TABLE(rpmsg, rpmsg_wwan_ctrl_id_table);
>
> ---
> base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
> change-id: 20230414-rpmsg-wwan-secondary-at-port-db72a66ce74a
>
> Best regards,
> --
> Jaime Breva <jbreva@nayarsystems.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-14 11:07 [PATCH] net: wwan: Expose secondary AT port on DATA1 Jaime Breva via B4 Relay
2023-04-14 14:14 ` Stephan Gerhold
2023-04-14 14:56 ` Loic Poulain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox