From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04598C77B70 for ; Mon, 17 Apr 2023 06:27:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230147AbjDQG1J (ORCPT ); Mon, 17 Apr 2023 02:27:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbjDQG1H (ORCPT ); Mon, 17 Apr 2023 02:27:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325D7359C; Sun, 16 Apr 2023 23:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MdcEqIopRGNeL8ynxUzh+Lk0gzYXw7VEdoDGuF/nCC4=; b=WJCZu+82Ms9YNKKRexfvrIz0CQ 5rd8KyfwBqTZIK8vlQEdi2tfQutHIcUeBeFnpFyde1kheiETzyWGdyodCxdK0LR2NGt//zf1MDoPo Dt6ikWhcz8fZ+uudi04lRvwud7EdV2kBCqqX6OGl5U7M5/INOXVeEbrqsRwlQdV5Cq5doaBQOBTCI U20l+C4YHkx6o0alQFNw9/jVnVwnAPV1YjhTI4GBACpg/zCTkzkzpoSPN9OPY+VFKGk1ik6fGBV2q vawsnlDV1Z32PMn36gCL0a+DYfg0jdLTfqbLo8mF1WIowd5EIM6XTr//qQ7dSF70eeuGlimIVBPLv IUvIi0Vw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1poIKK-00F3GR-2y; Mon, 17 Apr 2023 06:27:00 +0000 Date: Sun, 16 Apr 2023 23:27:00 -0700 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Pankaj Raghav , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org Subject: Re: [PATCH] mm/filemap: allocate folios according to the blocksize Message-ID: References: <20230414134908.103932-1-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 08:08:04AM +0200, Hannes Reinecke wrote: > On 4/17/23 06:36, Christoph Hellwig wrote: > > On Fri, Apr 14, 2023 at 03:49:08PM +0200, Hannes Reinecke wrote: > > > If the blocksize is larger than the pagesize allocate folios > > > with the correct order. > > > > And how is that supposed to actually happen? > > By using my patcheset to brd and set the logical blocksize to eg 16k. Then add it to your patchset instead of trying to add dead code to the kernel while also losing context.