public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: syzbot <syzbot+9a44753ac327c557796a@syzkaller.appspotmail.com>
Cc: adilger.kernel@dilger.ca, chris@chris-wilson.co.uk,
	dvyukov@google.com, jack@suse.cz, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, mika.kuoppala@linux.intel.com,
	rodrigo.vivi@intel.com, syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in ext4_set_page_dirty
Date: Sun, 30 Apr 2023 00:55:59 -0400	[thread overview]
Message-ID: <ZE3030tKPvwU7fIc@mit.edu> (raw)
In-Reply-To: <0000000000005a390a05b2361916@google.com>

#syz dup: WARNING in ext4_dirty_folio
#syz set subsystems: mm

ext4_set_page_dirty() was renamed to ext4_dirty_folio() in commit
e621900ad28b ("fs: Convert __set_page_dirty_buffers to
block_dirty_folio") in February 2022 --- which explains why it hasn't
reproduced in over 400 days,

(I assume marking it is the right thing to do, although the syzkaller
documentation doesn't explain exactly what happens after you mark the
report as a dup.  The other possibility would be to marking it as
invalid, to drop this as noise.  But that feels wrong, so I'm guessing
marking it as a dup is the best way to handle this kind of situation.)

I'm moving this to the mm subsystem, since the root cause is the
get_user_pages issue that has been with us for years, with discussions
as early as the 2018 LSF/MM.

					- Ted

      reply	other threads:[~2023-04-30  4:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01  8:05 WARNING in ext4_set_page_dirty syzbot
2018-04-19 16:08 ` Jan Kara
2018-05-21  6:07 ` syzbot
2018-05-21 12:50   ` Jan Kara
2018-06-13 15:55     ` Dmitry Vyukov
2020-10-21 22:45 ` syzbot
2023-04-30  4:55   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZE3030tKPvwU7fIc@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=chris@chris-wilson.co.uk \
    --cc=dvyukov@google.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.kuoppala@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=syzbot+9a44753ac327c557796a@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox