Re: [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

andy.shevchenko
2023-04-30T09:43:55Z

Sun, Apr 30, 2023 at 12:22:54PM +0800, Lizhe kirjoitti:
> to check if the pinctrl_dev still exists before calling
> pinctrl_unregister().

Besides commit message has no explanation (and English grammar
incorrectness)...

...

> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -1115,7 +1115,9 @@ int sprd_pinctrl_remove(struct platform_device *pdev)
> {
> struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);
>
> - pinctrl_unregister(sprd_pctl->pctl);

> + if (sprd_pctl->dev)

...this code is not needed.

> + pinctrl_unregister(sprd_pctl->pctl);
> return 0;
> }

NAK.

--
With Best Regards,
Andy Shevchenko