Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems

Greg Kroah-Hartman
2023-04-20T11:38:12Z

On Thu, Apr 13, 2023 at 04:44:21PM -0500, Andrew Davis wrote:
> Possibly the last PCI controller-based (i.e. not a soft/winmodem)
> dial-up modem one can still buy.
>
> Looks to have a stock XR17C154 PCI UART chip for communication, but for
> some reason when provisioning the PCI IDs they swapped the vendor and
> subvendor IDs. Otherwise this card would have worked out of the box.
>
> Searching online, some folks seem to not have this issue and others do,
> so it is possible only some batches of cards have this error.
>
> Create a new macro to handle the switched IDs and add support here.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> drivers/tty/serial/8250/8250_exar.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)

Please redo this without patch 1/2 as that would not make sense to
backport anywhere, but adding new device ids are allowed in stable
kernels. Also, as others pointed out, either convert them all or none
:)

thanks,

greg k-h