From: Chris Down <chris@chrisdown.name>
To: John Ogness <john.ogness@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
kernel-team@fb.com
Subject: Re: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
Date: Thu, 20 Apr 2023 14:47:40 +0100 [thread overview]
Message-ID: <ZEFCfJLteNo91n-f@chrisdown.name> (raw)
In-Reply-To: <87wn26vg3p.fsf@jogness.linutronix.de>
John Ogness writes:
>On 2023-04-20, Chris Down <chris@chrisdown.name> wrote:
>> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
>> index fd0c9f913940..06f16a5f1516 100644
>> --- a/kernel/printk/printk.c
>> +++ b/kernel/printk/printk.c
>> @@ -1289,15 +1289,13 @@ static int __init boot_delay_setup(char *str)
>> }
>> early_param("boot_delay", boot_delay_setup);
>>
>> -static void boot_delay_msec(int level)
>> +static void boot_delay_msec(void)
>> {
>> unsigned long long k;
>> unsigned long timeout;
>>
>> if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
>
> ^----- you will need to remove this paren as well
That'll teach me to compile test without remembering it also needs
CONFIG_BOOT_PRINTK_DELAY=y :-) Thanks.
>
>> - || suppress_message_printing(level)) {
>> return;
>> - }
>
>John Ogness
next prev parent reply other threads:[~2023-04-20 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:39 [PATCH v4 0/2] printk: console: Per-console loglevels Chris Down
2023-04-20 12:39 ` [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console Chris Down
2023-04-20 13:27 ` John Ogness
2023-04-20 13:47 ` Chris Down [this message]
2023-04-20 21:54 ` kernel test robot
2023-04-21 0:18 ` kernel test robot
2023-04-21 8:59 ` kernel test robot
2023-04-20 12:39 ` [PATCH v4 2/2] printk: console: Support console-specific loglevels Chris Down
2023-04-25 14:57 ` Petr Mladek
2023-04-27 13:53 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEFCfJLteNo91n-f@chrisdown.name \
--to=chris@chrisdown.name \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox