From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01F9C77B73 for ; Mon, 24 Apr 2023 15:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbjDXPW2 (ORCPT ); Mon, 24 Apr 2023 11:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231873AbjDXPWU (ORCPT ); Mon, 24 Apr 2023 11:22:20 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EF5B86BF; Mon, 24 Apr 2023 08:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682349738; x=1713885738; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qcfml2mDJ01bBf69Gj3gLLlNibuMy0QAooiEzfCDtEA=; b=fUwHShACM3/yxnHfxT/5HifGQuosKHcAwCo6YwlAPABjdw05WaxDi5w+ XHn3eUlhnKWRkwQoudDt23qB2q9kqFZm5x0Ea/WsLBG7MS+xQA8h1yvsb zsEDN+4WIU2JdhfO5xlKp0psHgSyyfk6+lBOnsxxKD9FTUNeZhWZXb/ZY Rlo+vnBImmzhb3KNNJnJ3Oq8Bd6OtKTD1K54BkCEhnLhpdFLQQ/F/xgeQ ffFVy7i2OhzzQMJs8hmvm4cNG4fEBAK5/Q+OS3kIsAPEr6JpXCyOQX+WO ByNDChwhxw8F3xY4F6xvHwxLSqoXgX406gYdJEOhsbaPih1302eSIhhDO Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="348389273" X-IronPort-AV: E=Sophos;i="5.99,223,1677571200"; d="scan'208";a="348389273" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 08:22:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="939365080" X-IronPort-AV: E=Sophos;i="5.99,223,1677571200"; d="scan'208";a="939365080" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 24 Apr 2023 08:22:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pqy15-004ZO9-1L; Mon, 24 Apr 2023 18:22:11 +0300 Date: Mon, 24 Apr 2023 18:22:11 +0300 From: Andy Shevchenko To: Matti Vaittinen Cc: Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Zhigang Shi , Shreeya Patel , Paul Gazzillo , Dmitry Osipenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 04:10:09PM +0300, Matti Vaittinen wrote: > The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear > and IR) with four configurable channels. Red and green being always > available and two out of the rest three (blue, clear, IR) can be > selected to be simultaneously measured. Typical application is adjusting > LCD backlight of TVs, mobile phones and tablet PCs. > > Add initial support for the ROHM BU27008 color sensor. > - raw_read() of RGB and clear channels > - triggered buffer w/ DRDY interrtupt ... This... > +#include ...is guaranteed to be included by this. > +#include ... > +static const struct of_device_id bu27008_of_match[] = { > + { .compatible = "rohm,bu27008", }, Inner comma is not necessary to have. > + { } > +}; -- With Best Regards, Andy Shevchenko