From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH 05/11] media: renesas: fdp1: remove R-Car H3 ES1.* handling
Date: Mon, 24 Apr 2023 21:17:30 +0200 [thread overview]
Message-ID: <ZEbVyhjKs15Rj+5h@sai> (raw)
In-Reply-To: <CAMuHMdVQiMbupkCYhZ86WHND25E==iA1DyVwGf2rg32zJLcV2g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
Hi Geert,
thanks for reporting!
> > -#define FD1_IP_H3_ES1 0x02010101
...
> Apparently 0x02010101 is also used on (at least) R-Car M2-W ES1.0,
> causing the following annoying (but further harmless?) messages
> during boot:
>
> rcar_fdp1 fe940000.fdp1: FDP1 Unidentifiable (0x02010101)
> rcar_fdp1 fe944000.fdp1: FDP1 Unidentifiable (0x02010101)
Hmm, that means before my removal patch, Gen2 has been incorrectly
defined as H3 ES1?
> Note that the R-Car Gen2 documentation states the register's contents
> are all zeroes. But that value would trigger the error message, too.
Bad, but well...
> Sorry for not noticing before. Apparently I never booted a kernel
> with this patch on koelsch...
We could re-add this version and just let it print "FDP1 Initial
Version" or something? I could test this on my Lager board.
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-24 19:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 16:30 [PATCH 00/11] tree-wide: remove support for Renesas R-Car H3 ES1 Wolfram Sang
2023-03-07 16:30 ` [PATCH 01/11] iommu/ipmmu-vmsa: remove R-Car H3 ES1.* handling Wolfram Sang
2023-03-22 13:28 ` Joerg Roedel
2023-03-07 16:30 ` [PATCH 02/11] drm: rcar-du: remove R-Car H3 ES1.* workarounds Wolfram Sang
2023-03-08 10:11 ` Kieran Bingham
2023-03-07 16:30 ` [PATCH 03/11] media: rcar-vin: remove R-Car H3 ES1.* handling Wolfram Sang
2023-03-07 16:30 ` [PATCH 04/11] media: rcar-vin: csi2: " Wolfram Sang
2023-03-07 16:30 ` [PATCH 05/11] media: renesas: fdp1: " Wolfram Sang
2023-03-08 0:36 ` Kieran Bingham
2023-04-24 17:37 ` Geert Uytterhoeven
2023-04-24 19:17 ` Wolfram Sang [this message]
2023-04-24 19:37 ` Geert Uytterhoeven
2023-04-24 23:52 ` Laurent Pinchart
2023-03-07 16:30 ` [PATCH 06/11] thermal/drivers/rcar_gen3_thermal: " Wolfram Sang
2023-03-08 18:04 ` Daniel Lezcano
2023-03-07 16:30 ` [PATCH 07/11] ravb: " Wolfram Sang
2023-03-07 17:21 ` Simon Horman
2023-03-08 9:39 ` Sergei Shtylyov
2023-03-07 16:30 ` [PATCH 08/11] mmc: renesas_sdhi: " Wolfram Sang
2023-03-09 15:02 ` Ulf Hansson
2023-03-07 16:30 ` [PATCH 09/11] usb: host: xhci-rcar: remove leftover quirk handling Wolfram Sang
2023-03-07 16:30 ` [PATCH 10/11] usb: host: xhci-rcar: remove R-Car H3 ES1.* handling Wolfram Sang
2023-03-07 16:30 ` [PATCH 11/11] usb: gadget: udc: renesas_usb3: " Wolfram Sang
2023-03-09 7:30 ` [PATCH 00/11] tree-wide: remove support for Renesas R-Car H3 ES1 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEbVyhjKs15Rj+5h@sai \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox