From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
"Liam Howlett" <liam.howlett@oracle.com>
Subject: Re: [RFC PATCH 1/3] Revert "binder_alloc: add missing mmap_lock calls when using the VMA"
Date: Tue, 25 Apr 2023 07:19:20 +0200 [thread overview]
Message-ID: <ZEdi2Gd_eWiJ1CrP@kroah.com> (raw)
In-Reply-To: <20230424205548.1935192-1-cmllamas@google.com>
On Mon, Apr 24, 2023 at 08:55:46PM +0000, Carlos Llamas wrote:
> This reverts commit 44e602b4e52f70f04620bbbf4fe46ecb40170bde.
>
> This caused a performance regression particularly when pages are getting
> reclaimed. We don't need to acquire the mmap_lock to determine when the
> binder buffer has been fully initialized. A subsequent patch will bring
> back the lockless approach for this.
>
> [cmllamas: resolved trivial conflicts with renaming of alloc->mm]
>
> Cc: Liam Howlett <liam.howlett@oracle.com>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
> drivers/android/binder_alloc.c | 31 ++++++++++---------------------
> 1 file changed, 10 insertions(+), 21 deletions(-)
Why is this series "RFC"? What needs to be done to be able to submit it
as a real patch series?
Also, as the commits you are reverting are in older kernels, please
properly cc: stable in the signed-off-by area, and add a fixes: tag for
the commit you are reverting when you resend these as a real series.
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-25 5:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 20:55 [RFC PATCH 1/3] Revert "binder_alloc: add missing mmap_lock calls when using the VMA" Carlos Llamas
2023-04-24 20:55 ` [RFC PATCH 2/3] Revert "android: binder: stop saving a pointer to " Carlos Llamas
2023-04-24 22:34 ` Liam R. Howlett
2023-04-24 23:11 ` Carlos Llamas
2023-04-25 1:43 ` Liam R. Howlett
2023-04-26 21:17 ` Carlos Llamas
2023-05-18 14:40 ` Liam R. Howlett
2023-05-18 17:03 ` Carlos Llamas
2023-04-24 20:55 ` [RFC PATCH 3/3] binder: add lockless binder_alloc_(set|get)_vma() Carlos Llamas
2023-04-25 5:19 ` Greg Kroah-Hartman [this message]
2023-04-26 21:22 ` [RFC PATCH 1/3] Revert "binder_alloc: add missing mmap_lock calls when using the VMA" Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEdi2Gd_eWiJ1CrP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox