Re: [PATCH] spi: remove return value check of debugfs_create_dir()

Mark Brown
2023-04-24T11:54:59Z

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
> Smatch complains that:
> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
> or valid
>
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.
>
> Just delete the dead code.

This is very much a question of taste with a range of use cases
available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]