From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E51EC77B73 for ; Thu, 27 Apr 2023 16:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244182AbjD0Q2H (ORCPT ); Thu, 27 Apr 2023 12:28:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233236AbjD0Q2E (ORCPT ); Thu, 27 Apr 2023 12:28:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABEDB10E; Thu, 27 Apr 2023 09:28:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 465A360F51; Thu, 27 Apr 2023 16:28:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D74BC433D2; Thu, 27 Apr 2023 16:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682612882; bh=sygxyc6bJpU/G8GGd4Uas2ekQmIkPh/RJ/FhruQwGxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tFjZdV7zhl9uUumZNfu0wBVvnGeZ2hwcuYdUN4cf//dFpowtme6rbXEsEHLh0YcRK vU5p9Kzih3lZmZRRAj1SbjOi3YRch9UCalQ5Bh9EzjKrjEwZ35lrNsCEHRhn5DGrFZ LU38paKFxKW0TjPidBaqC25hjJO5Z/+QIb8uXcfLVQgdcssXoxGd2MqSvWpBd18ZMz dqU5CwLLn/8kT1jvVgKHx5gB78yePAFm+ObHhRtGGYbRURiXn0Rw2m4VdYWnrH+jaX OBqdRS6XqwMn99jLMcKHqI1I+a9Q1ZljRMmASgfnIvLx5VY3fqDP1DmCoMUj1+PbRu DpT4sC3ILgVGw== Date: Thu, 27 Apr 2023 09:28:00 -0700 From: Jaegeuk Kim To: Dan Carpenter Cc: Christophe JAILLET , Chao Yu , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: remove some dead code Message-ID: References: <523ec4b037d064e92e19203e3ab9a161e3d9aa71.1681764681.git.christophe.jaillet@wanadoo.fr> <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18, Dan Carpenter wrote: > On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: > > > > - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); > > - if (!ret) > > - ret = ret2; > > + ret = filemap_check_errors(NODE_MAPPING(sbi)); > > > > return ret; > > Let's get rid of "ret" as well: > > return filemap_check_errors(NODE_MAPPING(sbi)); Applied with this modification. Thanks. > > regards, > dan carpenter