public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nipun Gupta <nipun.gupta@amd.com>,
	Nikhil Agarwal <nikhil.agarwal@amd.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Saravana Kannan <saravanak@google.com>
Subject: Re: [GIT PULL] Driver core updates for 6.4-rc1
Date: Fri, 28 Apr 2023 07:12:28 +0200	[thread overview]
Message-ID: <ZEtVvK6LTQHw6Onu@kroah.com> (raw)
In-Reply-To: <CAHk-=wjcvp-JxG2PW7TF6HV2h1xx2_2SMh_HGNZuEpK0CtNTww@mail.gmail.com>

On Thu, Apr 27, 2023 at 04:31:39PM -0700, Linus Torvalds wrote:
> On Thu, Apr 27, 2023 at 7:21 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > Once again, a busy development cycle, with lots of changes happening in
> > the driver core in the quest to be able to move "struct bus" and "struct
> > class" into read-only memory, a task now complete with these changes.
> 
> Well, this also caused a build failure, and I didn't catch it during
> the merge, because it only happened on arm64.
> 
> The reason it only happens on arm64 is that it is in the CDX bus
> driver, and that one has
> 
>         depends on OF && ARM64
> 
> despite apparently building fine on x86-64 too if you were to just add
> a "|| COMPILE_TEST" to it.
> 
> And I did notice this build failure eventually, since I do arm64
> builds on my M2 Macbook Air. But while it's a perfectly cromulent
> laptop, it's not like it's a speed daemon. It takes something like ~75
> minutes for afull allmodconfig build, so certainly not between each
> pull request.
> 
> End result: my merge test builds are all done on x86-64, and the arm64
> test builds happen much less regularly (ie: typically a couple of
> times a day).
> 
> I did the obvious fixup, but I can only assume (and hope) that this
> was caught by somebody else during the merge window, and that
> 
> > All of these have been in linux-next for a while with no reported
> > problems.
> 
> was just a lie.

Sorry about that, on it's own, it was fine, but merged with the
char-misc tree, there was a build issue, I had forgotten all about that.
I know we had already resolved one issue with merging this tree with the
DRM tree by reworking the DRM tree in advance, and that had pushed this
instance out of my memory.

In the future, how do you want stuff like "when this is merged with that
tree, something needs to be done" type of things to be pointed out?
linux-next keeps resolution patches around, do you want just a pointer
to that to make things easier?

And thanks for the fixup, it looks correct.

greg k-h

  reply	other threads:[~2023-04-28  5:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 14:20 [GIT PULL] Driver core updates for 6.4-rc1 Greg KH
2023-04-27 19:20 ` pr-tracker-bot
2023-04-27 23:31 ` Linus Torvalds
2023-04-28  5:12   ` Greg KH [this message]
2023-04-28 15:55     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEtVvK6LTQHw6Onu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=saravanak@google.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox