From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: p4ranlee@gmail.com, jolsa@kernel.org, namhyung@kernel.org,
irogers@google.com, Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, acme@redhat.com, anton@ozlabs.org,
dja@axtens.net, mpe@ellerman.id.au,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path
Date: Fri, 28 Apr 2023 22:23:23 -0300 [thread overview]
Message-ID: <ZExxi7KAW7W/OSwa@kernel.org> (raw)
In-Reply-To: <mhng-534349ae-0594-455c-bc27-da0d8a70d0be@palmer-ri-x1c9>
Em Tue, Apr 18, 2023 at 08:41:21PM -0700, Palmer Dabbelt escreveu:
> On Tue, 14 Mar 2023 22:15:01 PDT (-0700), p4ranlee@gmail.com wrote:
> > Add RISC-V binutils path on lookup triplets.
> >
> > Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> > ---
> > tools/perf/arch/common.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> > index 59dd875fd5e4..e80d4d22cabf 100644
> > --- a/tools/perf/arch/common.c
> > +++ b/tools/perf/arch/common.c
> > @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
> > NULL
> > };
> >
> > +const char *const riscv32_triplets[] = {
> > + "riscv32-unknown-linux-gnu-",
> > + "riscv32-linux-android-",
> > + "riscv32-linux-gnu-",
> > + NULL
> > +};
> > +
> > +const char *const riscv64_triplets[] = {
> > + "riscv64-unknown-linux-gnu-",
> > + "riscv64-linux-android-",
> > + "riscv64-linux-gnu-",
> > + NULL
> > +};
> > +
> > const char *const s390_triplets[] = {
> > "s390-ibm-linux-",
> > "s390x-linux-gnu-",
> > @@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
> > path_list = arm64_triplets;
> > else if (!strcmp(arch, "powerpc"))
> > path_list = powerpc_triplets;
> > + else if (!strcmp(arch, "riscv32"))
> > + path_list = riscv32_triplets;
> > + else if (!strcmp(arch, "riscv64"))
> > + path_list = riscv64_triplets;
> > else if (!strcmp(arch, "sh"))
> > path_list = sh_triplets;
> > else if (!strcmp(arch, "s390"))
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2023-04-29 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 5:15 [PATCH v2] perf tools riscv: Add support for riscv lookup_binutils_path Paran Lee
2023-03-16 0:11 ` Ian Rogers
2023-04-19 3:41 ` Palmer Dabbelt
2023-04-29 1:23 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZExxi7KAW7W/OSwa@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=anton@ozlabs.org \
--cc=aou@eecs.berkeley.edu \
--cc=dja@axtens.net \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=p4ranlee@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox