[PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[Ryan C. Underwood]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]


The Pavilion 15 line has B&O top speakers similar to the x360 and
applying the same profile produces good sound.  Without this, the sound
would be tinny and underpowered without either applying
model=alc295-hp-x360 or booting another OS first.
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e103bb3693c0..7cb232a23a08 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9335,7 +9335,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x802f, "HP Z240", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x103c, 0x8077, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x103c, 0x8158, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
-	SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
+	SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC295_FIXUP_HP_X360),
 	SND_PCI_QUIRK(0x103c, 0x8256, "HP", ALC221_FIXUP_HP_FRONT_MIC),
 	SND_PCI_QUIRK(0x103c, 0x827e, "HP x360", ALC295_FIXUP_HP_X360),
 	SND_PCI_QUIRK(0x103c, 0x827f, "HP x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
-- 
2.39.2


-- 
Ryan C. Underwood, <nemesis@icequake.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[Takashi Iwai]

On Wed, 10 May 2023 18:19:08 +0200,
Ryan C. Underwood wrote:
> 
> 
> The Pavilion 15 line has B&O top speakers similar to the x360 and
> applying the same profile produces good sound.  Without this, the sound
> would be tinny and underpowered without either applying
> model=alc295-hp-x360 or booting another OS first.

The code change looks OK, but could you give your Signed-off-by tag?
It's a legal requirement and mandatory for merging to the upstream.

Also, you can reduce the recipients in Cc a bit more.
For this kind of trivial change, just maintainers and ML should
suffice.


thanks,

Takashi

[PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[Ryan C. Underwood]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]


The Pavilion 15 line has B&O top speakers similar to the x360 and
applying the same profile produces good sound.  Without this, the
sound would be tinny and underpowered without either applying
model=alc295-hp-x360 or booting another OS first.

Signed-off-by: Ryan Underwood <nemesis@icequake.net>
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e103bb3693c0..7cb232a23a08 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9335,7 +9335,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x802f, "HP Z240", ALC221_FIXUP_HP_MIC_NO_PRESENCE),
        SND_PCI_QUIRK(0x103c, 0x8077, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
        SND_PCI_QUIRK(0x103c, 0x8158, "HP", ALC256_FIXUP_HP_HEADSET_MIC),
-       SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
+       SND_PCI_QUIRK(0x103c, 0x820d, "HP Pavilion 15", ALC295_FIXUP_HP_X360),
        SND_PCI_QUIRK(0x103c, 0x8256, "HP", ALC221_FIXUP_HP_FRONT_MIC),
        SND_PCI_QUIRK(0x103c, 0x827e, "HP x360", ALC295_FIXUP_HP_X360),
        SND_PCI_QUIRK(0x103c, 0x827f, "HP x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
-- 
2.39.2

-- 
Ryan C. Underwood, <nemesis@icequake.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[Takashi Iwai]

On Thu, 11 May 2023 19:32:21 +0200,
Ryan C. Underwood wrote:
> 
> 
> The Pavilion 15 line has B&O top speakers similar to the x360 and
> applying the same profile produces good sound.  Without this, the
> sound would be tinny and underpowered without either applying
> model=alc295-hp-x360 or booting another OS first.
> 
> Signed-off-by: Ryan Underwood <nemesis@icequake.net>

The patch seems mangled by your mailer (spaces instead of tabs).
I applied it manually as it's a trivial change.  But at the next time,
please check your mailer setup.

Also, please include all maintainers to Cc :)


thanks,

Takashi

Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

[Ryan C. Underwood]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Fri, May 12, 2023 at 10:28:14AM +0200, Takashi Iwai wrote:
> 
> The patch seems mangled by your mailer (spaces instead of tabs).
> I applied it manually as it's a trivial change.  But at the next time,
> please check your mailer setup.

Sorry, I pasted to terminal from another system and that must have
mangled it.

> Also, please include all maintainers to Cc :)

Apologies for my ignorance, but what's the correct way to get "all
maintainers" if not scripts/get_maintainer.pl, which you said produced
too many cc's in the previous attempt?

-- 
Ryan C. Underwood, <nemesis@icequake.net>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]